[Feat] 인증 원격 데이터 소스 구현 - #85
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds authentication DTOs, provider mapping, endpoint targets, and an injected remote data source for login, token reissue, logout, and withdrawal, with contract tests covering routing, validation, responses, and sensitive-data logging. ChangesAuthentication remote contract
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Constraint: v2 네트워크 기반과 서버 인증 API 계약을 유지 Rejected: UI·Keychain·런타임 주입 동시 도입 | 계층별 검토와 회귀 격리를 위해 제외 Confidence: high Scope-risk: narrow Directive: 신규 provider와 DTO는 unknown·누락 필드 호환성을 유지할 것 Tested: 기존 PR HEAD와 tree 동일; PR 기록상 전체 XCTest 308개 및 Foundation·SwiftData gate 성공 Not-tested: 실제 iPhone 검증
MinHeokChoi
force-pushed
the
feat/#84-auth-remote-contracts
branch
from
July 28, 2026 02:57
73a2cda to
4461fa0
Compare
MinHeokChoi
changed the base branch from
chore/#81-v2-network-foundation
to
main
July 28, 2026 02:57
MinHeokChoi
marked this pull request as ready for review
July 28, 2026 02:59
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
AuthProvider를 추가했습니다.AuthTarget을 추가하고/auth/reissue의X-Refresh-Token헤더 계약을 고정했습니다.isNewMember가 누락된 응답과 신규 provider raw value를 안전하게 처리합니다.DefaultAuthRemoteDataSource와 deterministic stub/error 계약 테스트를추가했습니다.
포함하지 않았습니다.
검증
bash Scripts/check-iphone-functional-gate.sh: passedbash Scripts/check-swiftdata-boundary.sh: passedplutil -lint Moru/Info.plist: passedgit diff --check: passed📋 추후 진행 상황
AccountSessionStore기반을 추가합니다.📌 리뷰 포인트
isNewMember누락과 unknown provider가 decoding 실패를 만들지 않는지 확인해 주세요.✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요!!!
Closes #84
Summary by CodeRabbit
New Features
Tests