[Feat] 서버 선택 기능의 로컬 우선 저장 기반 구현 - #95
Draft
MinHeokChoi wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
MoruSchemaV4와 명시적인 V3 → V4 lightweight migration stage를 추가했습니다.PersistedServerMutation,PersistedVoiceCatalogEntry와 SwiftDatarepository를 추가했습니다.
coalescing합니다. 실행 중 새 값이 coalesce되어도 이전 응답이 새 mutation을
삭제하거나 backoff하지 않도록 idempotency generation을 검증합니다.
exponential backoff합니다. 실패 mutation은 자동 폐기하지 않습니다.
SyncCoordinatortrigger로 연결했습니다.P6에는 실제 서버 Target이 없으므로 runtime executor는 queue를 변경하지 않고
deferred합니다.
AccountScopedDataCleaning을 해당 계정 Outbox와 voice cache 삭제에 연결했습니다.다른 계정과 LocalProfile, Routine, AlarmSchedule, RoutineRun, snapshot, platform
state는 유지합니다.
localOnly, hard delete 계약은 변경하지 않았습니다.검증:
state 보존: 통과
통과
📋 추후 진행 상황
GET /tts,PATCH /members/me/ttsTarget과 executor, 음성 선택 UI를구현합니다.
QA로 남깁니다.
📌 리뷰 포인트
확인해 주세요.
보존하는지 확인해 주세요.
localOnly/hard-delete 계약이 변경되지 않았는지 확인해 주세요.✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요!!!
Closes #94