[Feat] 서버 루틴 추천과 로컬 fallback 구현 - #99
Draft
MinHeokChoi wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
POST /routine-groups/ai-generateTarget·DTO·RemoteDataSource를 추가했습니다.ServerRoutineSuggestionService가 routine/step title, description, 130개 step, exact3600초를 검증합니다.CHECK/TIMER/INPUT, step별 1localOnly인 editable draft로 변환합니다.RoutineSuggestionCoordinator가 로그인 중에만 서버를 시도하고 signed-out, airplane/transport, timeout, 5xx, decoding, missing result, validation 실패에서는 기존LocalTemplateSuggestionService를 사용합니다.서버 맞춤 추천/기기 내 추천으로 표시하되 원시 오류나 사용자 입력은 UI에 노출하지 않습니다.검증
bash Scripts/check-iphone-functional-gate.sh: passedbash Scripts/check-swiftdata-boundary.sh: passedplutil -lint Moru/Info.plist Moru/Moru/Moru.entitlements: passedgit diff --check: passed📋 추후 진행 상황
📌 리뷰 포인트
✅ Checklist
localOnly계약을 유지했습니다Closes #98