feat(session): 면접 세션 도메인 + Core/AI 메시지 DTO#31
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
고생하셨습니다. |
i3months
added a commit
that referenced
this pull request
May 29, 2026
origin/dev 동료(서현) PR #31 (feat(session): 면접 세션 도메인 + Core/AI 메시지 DTO) 흡수. 충돌 해결 원칙: 내 풀스택 동작 코드 유지, 동료의 좋은 부분만 흡수. - DTO 4개 (GenerateQuestionsPayload, GenerateFollowupPayload, QuestionsCallbackPayload, QuestionsCallbackEnvelope): 동료 것은 미사용 데드코드 (Service 없음). 내 풀스택 동작 코드 채택. - InterviewSession: 내 `start/end/interrupt/cancel/updateTitleAndMemo` 유지, 동료의 `isMaxReached()` 흡수. - InterviewMessage: 내 `interviewer(no parent) / followup(with parent) / interviewee(with parent + idempotencyKey)` 시그니처 유지, 동료의 null/blank/sequence 검증 로직을 단일 생성자에 흡수. - InterviewMessageRepository: 내 메서드 + 동료의 `findMaxSequenceBySessionId` 흡수. - InterviewSessionRepository, SessionContextRepository: 내 메서드 유지 (동료 메서드는 미사용 + 필드명 부정확). - 동료의 도메인 테스트 3개 (InterviewSessionTest, InterviewMessageTest, QuestionsCallbackPayloadTest): 시그니처·스키마가 내 코드와 호환 불가, 내 SessionServiceTest/InterviewMessageServiceTest/QuestionsCallbackServiceTest 가 같은 영역을 서비스 레이어에서 커버하므로 제거.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
session관련 DTO 등을 추가했습니다. 스프린트 2 작업에 필요한 내용들입니다