Skip to content

Adding FB1 article to main branch - #78

Merged
gkapfham merged 4 commits into
TeamDevDev:masterfrom
Aidana-Kuat:master
Sep 2, 2026
Merged

gkapfham merged 4 commits into
TeamDevDev:masterfrom
Aidana-Kuat:master

Conversation

@kathrynboidock

Copy link
Copy Markdown
Contributor

Here is our PR to our fork that holds our article and project!!

@gkapfham gkapfham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lab00 directory with a subproject commit message that should not be a part of the PR.

@gkapfham

gkapfham commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Note that, by default, this PR will break the build because of the problem with the lab00 directory that is a submodule.

@gkapfham

gkapfham commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This article also has spelling mistakes in it, including one spelling mistake in the first paragraph.

@gkapfham

gkapfham commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Going forward, please make sure to use conventional commit messages and you have seen we always try to do for the source code in this course web site. Thanks!

@gkapfham

gkapfham commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Unless there is something that I am overlooking, it seems as though two members of this team did not make any commits to the GitHub repository for this article. Can you please send me a DM to explain why that is the case?

@gkapfham
gkapfham merged commit 237c1f3 into TeamDevDev:master Sep 2, 2026
1 check failed
@kathrynboidock

Copy link
Copy Markdown
Contributor Author

I see that you have merged the request. Can I still go back and fix any spelling mistakes? I do not want things such as that to reflect poorly on our article!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants