fix: wrong cobblemon apricorn texture paths#29
Conversation
They probably were in earlier versions, but the texture path for apricorn logs are incorrect and was causing null textures Changing model textures to `"cobblemon:block/wood/*"` fixes issue #21 https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Round Trees to v8.3 by correcting Cobblemon apricorn log model texture paths and reflecting the change in metadata and changelog.
Changes:
- Bump pack description version from 8.2 to 8.3
- Fix Cobblemon apricorn log / stripped apricorn log model texture paths to use
cobblemon:block/wood/... - Add v8.3 entry to the changelog
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pack.mcmeta | Updates displayed pack version to 8.3 |
| input/assets/cobblemon/models/block/apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| input/assets/cobblemon/models/block/stripped_apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| assets/cobblemon/models/block/apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| assets/cobblemon/models/block/stripped_apricorn_log.json | Points model textures to cobblemon:block/wood/... |
| CHANGELOG.md | Documents the texture-path fix in v8.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "min_format": 15, | ||
| "max_format": 255, | ||
| "description": "§2Version 8.2\n§e©Motschen 2026 | MIT Licence" | ||
| "description": "§2Version 8.3\n§e©Motschen 2026 | MIT Licence" |
|
that should make copilot happy 😆 |
|
@Motschen I would appreciate a review at your earliest convenience :) its been tested in both major supported versions of Cobblemon |
|
Awesome – thanks a lot! |
|
Hahahah Microsoft/GitHub been pushing Copilot on everyone, these days it's an opt-out not opt-in thing Appreciate the merge homie, have a good Friday and weekend |
They probably were in much earlier versions, but the texture path for apricorn logs/stripped logs are incorrect and was causing null textures as seen in #21
Changing model textures to
"cobblemon:block/wood/*"fixes #21Reference
https://gitlab.com/cable-mc/cobblemon/-/tree/main/common/src/main/resources/assets/cobblemon/textures/block/wood
Tested Result
Note: tested in both 1.20.1 and 1.21.1
--
FYI was unsure if I was supposed to edit the
./input/assetstoo, but I did anyway as I would like to get this merged asap -- perhaps a contributing guide would be nice for future potential maintainers!