fix: keep the login fields above the software keyboard - #55
Merged
Conversation
KeyboardAvoidingView measures its own frame relative to its parent. The auth flow put the safe-area insets on that parent, so the view under-shot by exactly insets.top + insets.bottom — around 93pt on a notched iPhone — and the keyboard covered the inputs. Android had no behavior set at all, which stopped working once the app went edge-to-edge: the window no longer resizes under the IME. - move the safe-area padding inside the avoiding view, so its frame spans the whole screen and the displacement equals the keyboard height - give Android behavior="height", matching the other screens - carry the bottom inset on the scroll content instead - drop the brand mark while typing so short screens keep the whole form visible, and allow a swipe to dismiss the keyboard Applies to every step of the flow (server, login, TOTP, signup, reset).
Member
|
LGTM, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The keyboard covered the input fields in the auth flow. Fixed for every step (server, login, TOTP, signup, reset).
Changes Made
KeyboardAvoidingViewmeasures its own frame relative to its parent. The auth flow put the safe-area insets on that parent, so the view under-shot by exactlyinsets.top + insets.bottom— around 93pt on a notched iPhone — and the keyboard covered the inputs. On Android nobehaviorwas set at all, which stopped working once the app went edge-to-edge: the window no longer resizes under the IME.behavior="height", matchingDialogandTwoFactorAuthChecklist
Notes
The same pattern still exists in
QuickConnect(sheet input, no Android behavior) — left out of scope here.Pre-existing on
main(not from this branch):format:check,tsc --noEmitandverify:android-network-securityalready fail.🤖 AI assisted code with Claude Code