fix: ignore members of types that fail to load#203
Merged
Conversation
Reflecting over the members of a successfully loaded type can throw when a member signature references a type from an assembly that cannot be resolved. Guard each GetDeclared* helper with a try/catch that falls back to an empty array on TypeLoadException, FileNotFoundException or FileLoadException, so a single unloadable member no longer aborts the whole query. The caught set is scoped to exceptions these member getters can actually raise: ReflectionTypeLoadException (only thrown by Assembly/Module type enumeration) and BadImageFormatException (thrown at assembly load time) are intentionally excluded.
|
👽 Mutation ResultsaweXpect.ReflectionDetails
The final mutation score is 98.22%Coverage Thresholds: high:80 low:60 break:0 |
🚀 Benchmark ResultsDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflecting over the members of a successfully loaded type can throw when a member signature references a type from an assembly that cannot be resolved. Guard each GetDeclared* helper with a try/catch that falls back to an empty array on TypeLoadException, FileNotFoundException or FileLoadException, so a single unloadable member no longer aborts the whole query.
The caught set is scoped to exceptions these member getters can actually raise: ReflectionTypeLoadException (only thrown by Assembly/Module type enumeration) and BadImageFormatException (thrown at assembly load time) are intentionally excluded.