feat!: match parameter subtypes in WithParameter and add WithExactParameter#206
Merged
Merged
Conversation
…ameter Make `WithParameter<T>` on methods and constructors match parameters assignable to `T` (including subtypes) instead of requiring an exact type, mirroring `WhichReturn<T>`. Add `WithExactParameter<T>` for the previous exact-match behavior, mirroring `WhichReturnExactly<T>`. BREAKING CHANGE: `WithParameter<T>()` now matches parameters of subtypes of `T`. Use `WithExactParameter<T>()` to restore exact-type matching.
|
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpect.ReflectionDetails
The final mutation score is 80.77%Coverage Thresholds: high:80 low:60 break:0 |
|
This is addressed in release v1.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
WithParameter<T>on methods and constructors match parameters assignable toT(including subtypes) instead of requiring an exact type, mirroringWhichReturn<T>. AddWithExactParameter<T>for the previous exact-match behavior, mirroringWhichReturnExactly<T>.BEHAVIOR CHANGE:
WithParameter<T>()now matches parameters of subtypes ofT. UseWithExactParameter<T>()to restore exact-type matching.WithParameter<T>uses exact type matching — inconsistent withWhichReturn<T>#204