fix: DocGen reject restores full typed card for all block types

ijbo · ijbo · commit 55538f3d6cbb · 2026-04-03T00:03:37.000+09:00
- Fixed: rejecting Translate block showed generic AI Generate card (missing language dropdown) - Fixed: rejecting OCR/TTS/STT/Image/AI blocks lost all type-specific UI - Reject handler now uses M.transformDocgenMarkdown(block.fullMatch) to re-render exact original card - data-ai-index patched on restored card and all child elements after re-render - Review panel header now shows correct icon+label per type (🌐 Translate, 🔍 OCR, etc.) - README: backfilled commit IDs for recent entries (f012a30, 971de55, 6f495fe, 1519804, fe7bde6)
diff --git a/README.md b/README.md
@@ -544,10 +544,11 @@ TextAgent has undergone significant evolution since its inception. What started
 
 | Date | Commits | Feature / Update |
 |------|---------|-----------------:|
-| **2026-04-02** | | ⚡ **Share Link Loading Overlay** — eliminates the flash of bare UI when opening shared links (`#space=`, `#s=`, `#id=`, `#d=`); full-screen branded loading splash (TextAgent logo + spinner) activates before any JS loads via inline hash detection in `<head>`; theme-aware (dark `#0d1117` / light `#f6f8fa`); fades out smoothly (0.35s) once content is ready; `hideShareLoader()` called at every terminal path (success, error, form-gate); 15-second safety timeout auto-dismisses on network failure |
-| **2026-04-02** | | ✏️ **Annotate DocGen + Pretext Reflow Engine** — new `{{Annotate:}}` DocGen tag with canvas-based freehand annotation overlay; `@text:` source mode renders text on-canvas with real-time Pretext-style scanline reflow (~0.5–1.5ms/frame, O(width) per row); freehand strokes build an offscreen mask; per-row `getImageData` scans free x-intervals; words packed into intervals via `canvas.measureText()` (same arithmetic as Pretext `layoutNextLine()`); tools: pen, highlighter, eraser, line, arrow, rect, circle; color swatches + size slider; `📖 Present` button calls `M.setViewMode('preview')` — hides editor, annotation stays fully drawable while reading; `↩ Undo` / `🗑 Clear` / `📥 PNG` actions; Fixed: `data-text` stripped by DOMPurify — added `data-text`, `data-reflow` to `ADD_ATTR` + hidden `<span class="ann-reflow-text">` textContent as primary storage (survives sanitization without whitelisting); `annotate-docgen.js` (~710 lines) + `annotate-docgen.css` (~340 lines); interactive demo: `public/pretext-reflow-demo.html` — 4-tab demo (Float Image, Draw Exclusion, Both Together, API explainer) |
-| **2026-04-02** | | 📬 **Space Recovery by Email + Email Link Fix** — Spaces "Recover" view now has two tabs: **By Email** (default — enter email + access key, Firestore queries by hashed `eh` field to recover all matching spaces) and **By Slug** (existing flow); email pre-filled from localStorage; recovers multiple spaces at once if same key used; "Email to Self" now embeds all generated links (Share Link, Editor Link, Respondent Link, Password) directly in the email body so they always appear in the sent email |
-| **2026-04-02** | | 🔬 **Research Loop UX Fixes** — fixed table-tools toolbar hijacking research results table (skips `research-results-table` class); fixed results table `max-height: 350px` clipping to `600px`; moved `research-loop.js` import to Phase 3b-ext3 with try/catch to prevent silent load failures; clicking row now shows only the extracted `PROMPT` text with `📋 Copy` button (not full scorer code); added search pills panel (`@search:` field) with provider API key prompts; DOMPurify allowlist expanded for `input`, `label`, `checked`, `data-research-*` attrs; iframe sandbox height raised from 800→5000px |
+| **2026-04-02** | `(pending)` | 🔧 **DocGen Reject Block Fix** — fixed: rejecting a generated Translate/OCR/TTS/STT/Image/AI block restored a generic hardcoded "AI Generate" card, losing all type-specific UI (language dropdown, mode pills, camera button, step inputs, etc.); reject handler now calls `M.transformDocgenMarkdown(block.fullMatch)` to re-render the exact original typed card with all controls intact; `data-ai-index` patched on restored card and all children; review panel header label+icon now shows correct type for all blocks ("🌐 Translate — Review", "🔍 OCR Scan — Review", etc.) instead of always "✨ AI Generate — Review" |
+| **2026-04-02** | `f012a30`, `971de55` | ⚡ **Share Link Loading Overlay** — eliminates the flash of bare UI when opening shared links (`#space=`, `#s=`, `#id=`, `#d=`); full-screen branded loading splash (TextAgent logo + spinner) activates before any JS loads via inline hash detection in `<head>`; theme-aware (dark `#0d1117` / light `#f6f8fa`); fades out smoothly (0.35s) once content is ready; `hideShareLoader()` called at every terminal path (success, error, form-gate); 15-second safety timeout auto-dismisses on network failure |
+| **2026-04-02** | `6f495fe` | ✏️ **Annotate DocGen + Pretext Reflow Engine** — new `{{Annotate:}}` DocGen tag with canvas-based freehand annotation overlay; `@text:` source mode renders text on-canvas with real-time Pretext-style scanline reflow (~0.5–1.5ms/frame, O(width) per row); freehand strokes build an offscreen mask; per-row `getImageData` scans free x-intervals; words packed into intervals via `canvas.measureText()` (same arithmetic as Pretext `layoutNextLine()`); tools: pen, highlighter, eraser, line, arrow, rect, circle; color swatches + size slider; `📖 Present` button calls `M.setViewMode('preview')` — hides editor, annotation stays fully drawable while reading; `↩ Undo` / `🗑 Clear` / `📥 PNG` actions; Fixed: `data-text` stripped by DOMPurify — added `data-text`, `data-reflow` to `ADD_ATTR` + hidden `<span class="ann-reflow-text">` textContent as primary storage (survives sanitization without whitelisting); `annotate-docgen.js` (~710 lines) + `annotate-docgen.css` (~340 lines); interactive demo: `public/pretext-reflow-demo.html` — 4-tab demo (Float Image, Draw Exclusion, Both Together, API explainer) |
+| **2026-04-02** | `1519804` | 📬 **Space Recovery by Email + Email Link Fix** — Spaces "Recover" view now has two tabs: **By Email** (default — enter email + access key, Firestore queries by hashed `eh` field to recover all matching spaces) and **By Slug** (existing flow); email pre-filled from localStorage; recovers multiple spaces at once if same key used; "Email to Self" now embeds all generated links (Share Link, Editor Link, Respondent Link, Password) directly in the email body so they always appear in the sent email |
+| **2026-04-02** | `fe7bde6` | 🔬 **Research Loop UX Fixes** — fixed table-tools toolbar hijacking research results table (skips `research-results-table` class); fixed results table `max-height: 350px` clipping to `600px`; moved `research-loop.js` import to Phase 3b-ext3 with try/catch to prevent silent load failures; clicking row now shows only the extracted `PROMPT` text with `📋 Copy` button (not full scorer code); added search pills panel (`@search:` field) with provider API key prompts; DOMPurify allowlist expanded for `input`, `label`, `checked`, `data-research-*` attrs; iframe sandbox height raised from 800→5000px |
 | **2026-04-01** | | 🔬 **Research Loop Tag** — new `{{@Research:}}` tag for autonomous AI-driven experiment optimization (inspired by Karpathy's autoresearch); Propose→Execute→Evaluate→Keep/Discard loop runs entirely in-browser via Pyodide (Python in WASM); configurable `@metric`, `@direction` (lower/higher), `@max_iterations`, `@model`, `@goal`; multiline `@code: \|` (mutable) and `@test: \|` (fixed harness) fields; metric extraction from stdout (`METRIC:xxx`); AI prompt includes experiment history with strategy shift hints after 3 consecutive failures; live results table with status badges (baseline/keep/discard/crash), delta indicators, progress bar; per-card model selector; Start/Stop controls; glass card UI with purple accents and pulse animation; `js/research-loop.js` (~795 lines) + `css/research-loop.css` (~300 lines) |
 | **2026-04-01** | | 🎨 **AI Panel UI Redesign** — centered initial chat state (Claude-like welcome with input + model selector clustered in middle, transitions to bottom-pinned on first message via CSS `:has(.ai-welcome-message)`); merged separate Attach File (paperclip) and Screenshot (camera) buttons into single `+` button with unified dropdown menu (Attach File / Capture Page / Capture Screen / Upload Image, `+` rotates to `×` when open); merged header bar and status bar into single compact header (status text inline below title, download progress bar still standalone); fixed download progress bar stuck at 96% after model load |
 | **2026-03-31** | | 📷 **Screenshot to AI** — new 📷 camera button in the AI chat input bar with three capture modes: Capture Page (`html2canvas` full-page snapshot, AI panel hidden during capture), Capture Screen (`getDisplayMedia` screen-share with frame extraction from a hidden DOM-attached video element), and Upload Image (file picker); captured image auto-injected into `pendingAttachments` and sent to AI for analysis; fixed black-screen capture bug (video must be in DOM for GPU decoder, wait for `timeupdate` event not just `requestAnimationFrame`); self-healing button injection via `injectButtonIfMissing()` with 2s fallback poll; CSS-independent dropdown via inline `style.display` toggling; vision model warning toast; `js/ai-screenshot.js` new module (~300 lines) + `css/ai-panel.css` styles + `js/modal-templates.js` template update + `src/main.js` registration |
diff --git a/changelogs/CHANGELOG-docgen-reject-fix.md b/changelogs/CHANGELOG-docgen-reject-fix.md
@@ -0,0 +1,35 @@
+# DocGen Reject Fix — Restore Full Typed Card on Reject
+
+- Fixed: Rejecting a generated Translate block restored a generic "AI Generate" card instead of the proper Translate card with language dropdown
+- Fixed: Rejecting a generated OCR block lost mode pills, camera button, and upload button
+- Fixed: Rejecting any specialized block (Translate, OCR, TTS, STT, etc.) always showed a generic "AI Generate" card missing all type-specific UI
+- Fixed: Review panel header showed wrong icon and label ("✨ AI Generate") for Translate, OCR, TTS, STT, and Image blocks — now correctly shows "🌐 Translate — Review", "🔍 OCR Scan — Review", etc.
+- Reject handler now uses `M.transformDocgenMarkdown(block.fullMatch)` to re-render the exact original block into its full typed card
+- `data-ai-index` attribute patched on the restored card and all child elements so button actions remain correctly bound after reject
+- Fallback minimal card included in case `transformDocgenMarkdown` produces no output (defensive)
+
+---
+
+## Summary
+
+When users clicked **Reject** on a generated AI block, the review handler rebuilt a hardcoded generic "AI Generate" card for all block types. For `{{@Translate:}}` blocks this dropped the language selection dropdown; for `{{@OCR:}}` blocks it dropped the mode pills, camera, and upload buttons; for other types similar UI was lost. This fix re-renders the original DocGen tag markdown through the existing `transformDocgenMarkdown` renderer, producing a bit-perfect typed card restoration regardless of block type.
+
+---
+
+## 1. Reject Handler — Full Card Restoration
+**Files:** `js/ai-docgen-generate.js`
+**What:** Replaced the hardcoded "AI Generate" card HTML in the `handleDecision('reject')` branch of `showReviewPanel()` with a call to `M.transformDocgenMarkdown(block.fullMatch)`, which produces the same full card HTML as the initial render. The resulting DOM node is patched to restore the correct `data-ai-index` (since `transformDocgenMarkdown` always counts from index 0), then swapped into the preview pane. `M.bindDocgenPreviewActions()` is called after the swap to re-bind all button handlers.
+**Impact:** Translate blocks restore with language dropdown + model selector. OCR blocks restore with mode pills + camera + upload. Agent blocks restore with step inputs + search pills + cloud toggle. All other typed block UIs (TTS, STT, Image, Memory) are likewise correct after reject.
+
+## 2. Review Panel Header Label Fix
+**Files:** `js/ai-docgen-generate.js`
+**What:** The review panel header `icon` and `typeLabel` variables were previously only checking for `block.type === 'Think'` and defaulting to `✨ / AI Generate` for everything else. Extended the ternary chain to cover all DocGen types: Translate → `🌐`, OCR → `🔍`, TTS → `🔊`, STT → `🎤`, Image → `🖼️`, AI/Think → `✨/🧠`.
+**Impact:** The review panel header now correctly shows e.g. "🌐 Translate — Review" or "🔍 OCR Scan — Review" instead of always "✨ AI Generate — Review".
+
+---
+
+## Files Changed (1 total)
+
+| File | Lines Changed | Type |
+|------|:---:|------|
+| `js/ai-docgen-generate.js` | +29 −28 | Bug fix — reject handler + review header label |
diff --git a/js/ai-docgen-generate.js b/js/ai-docgen-generate.js
@@ -441,8 +441,8 @@
             reviewCard.className = 'ai-inline-review';
             reviewCard.dataset.aiType = block.type;
 
-            var icon = block.type === 'Think' ? '🧠' : '✨';
-            var typeLabel = block.type === 'Think' ? 'Think' : 'AI Generate';
+            var icon = block.type === 'Think' ? '🧠' : block.type === 'Translate' ? '🌐' : block.type === 'OCR' ? '🔍' : block.type === 'TTS' ? '🔊' : block.type === 'STT' ? '🎤' : block.type === 'Image' ? '🖼️' : '✨';
+            var typeLabel = block.type === 'Think' ? 'Think' : block.type === 'Translate' ? 'Translate' : block.type === 'OCR' ? 'OCR Scan' : block.type === 'TTS' ? 'Text to Speech' : block.type === 'STT' ? 'Speech to Text' : block.type === 'Image' ? 'Image Generate' : 'AI Generate';
 
             reviewCard.innerHTML =
                 '<div class="ai-inline-review-header">'
@@ -476,32 +476,33 @@
                 resolved = true;
                 resolve(decision);
                 if (decision === 'reject' && placeholderCard) {
-                    var models = window.AI_MODELS || {};
-                    var modelIds = Object.keys(models);
-                    var currentModel = (M.getCurrentAiModel ? M.getCurrentAiModel() : modelIds[0]) || modelIds[0];
-                    var modelOptionsHtml = '';
-                    modelIds.forEach(function (id) {
-                        var m = models[id];
-                        var name = m.dropdownName || m.label || id;
-                        var sel = id === currentModel ? ' selected' : '';
-                        modelOptionsHtml += '<option value="' + id + '"' + sel + '>' + name + '</option>';
-                    });
-                    var newCard = document.createElement('div');
-                    newCard.className = 'ai-placeholder-card';
-                    newCard.dataset.aiType = block.type;
-                    newCard.dataset.aiIndex = blockIndex;
-                    var icon = block.type === 'Think' ? '🧠' : '✨';
-                    var label = block.type === 'Think' ? 'Think' : 'AI Generate';
-                    newCard.innerHTML =
-                        '<div class="ai-placeholder-header">'
-                        + '<span class="ai-placeholder-icon">' + icon + '</span>'
-                        + '<span class="ai-placeholder-label">' + label + '</span>'
-                        + '<div class="ai-placeholder-actions">'
-                        + '<select class="ai-card-model-select" data-ai-index="' + blockIndex + '" title="Model for this generation">' + modelOptionsHtml + '</select>'
-                        + '<button class="ai-placeholder-btn ai-fill-one" data-ai-index="' + blockIndex + '" title="Generate this block">▶</button>'
-                        + '<button class="ai-placeholder-btn ai-remove-tag" data-ai-index="' + blockIndex + '" title="Remove tag">✕</button>'
-                        + '</div></div>'
-                        + '<div class="ai-placeholder-prompt">' + block.prompt + '</div>';
+                    // Re-render the original block's full markdown back into its proper typed card
+                    // (preserves language dropdown for Translate, steps for Agent, etc.)
+                    var restoredHtml = M.transformDocgenMarkdown(block.fullMatch);
+                    var tempDiv = document.createElement('div');
+                    tempDiv.innerHTML = restoredHtml;
+                    var newCard = tempDiv.querySelector('.ai-placeholder-card') || tempDiv.firstElementChild;
+                    if (!newCard) {
+                        // Fallback: build a minimal generic card if transform fails
+                        newCard = document.createElement('div');
+                        newCard.className = 'ai-placeholder-card';
+                        newCard.dataset.aiType = block.type;
+                        newCard.dataset.aiIndex = String(blockIndex);
+                        var icon = block.type === 'Think' ? '🧠' : block.type === 'Translate' ? '🌐' : '✨';
+                        var label = block.type === 'Think' ? 'Think' : block.type === 'Translate' ? 'Translate' : 'AI Generate';
+                        newCard.innerHTML =
+                            '<div class="ai-placeholder-header">'
+                            + '<span class="ai-placeholder-icon">' + icon + '</span>'
+                            + '<span class="ai-placeholder-label">' + label + '</span>'
+                            + '</div>'
+                            + '<div class="ai-placeholder-prompt">' + block.prompt + '</div>';
+                    } else {
+                        // Fix up the block index in case transformDocgenMarkdown assigned index 0
+                        newCard.dataset.aiIndex = String(blockIndex);
+                        newCard.querySelectorAll('[data-ai-index]').forEach(function (el) {
+                            el.dataset.aiIndex = String(blockIndex);
+                        });
+                    }
                     reviewCard.parentNode.replaceChild(newCard, reviewCard);
                     M.bindDocgenPreviewActions(newCard.parentNode);
                 } else if (decision === 'accept') {
