Skip to content

(DO NOT MERGE) ORFS QoR check for latch D-input path optimization#4339

Open
jhkim-pii wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-rsz-time-borrow-opt
Open

(DO NOT MERGE) ORFS QoR check for latch D-input path optimization#4339
jhkim-pii wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-rsz-time-borrow-opt

Conversation

@jhkim-pii

Copy link
Copy Markdown
Contributor

Summary

  • Bump the OpenROAD submodule to the latest secure-rsz-time-borrow-opt commit.
  • Enable ORFS CI coverage for the RSZ latch time-borrow repair updates and empty violator debug-log cleanup.

Problem

  • ORFS is still pinned to an older OpenROAD commit and does not exercise the latest RSZ changes in flow-level CI.
  • The OpenROAD PR needs corresponding ORFS secure and public CI coverage to check QoR and metric impact.

Solution

  • Update tools/OpenROAD from 8eade99b1 to 9896dd27ff.
  • Include the current OpenROAD RSZ time-borrow repair commits and the RSZ-0008 logging cleanup.

Impact

  • No ORFS script or design configuration changes.
  • Flow impact is limited to the OpenROAD engine submodule update.
  • CI should report whether the RSZ changes introduce QoR, metric, or regression changes.

Testing

  • OpenROAD local RSZ regression passed: bazelisk test //src/rsz/test:all --cache_test_results=no --test_output=errors.
  • ORFS CI is expected to run from this PR.

Reviewer Notes

  • Review the CI metric and QoR deltas for RSZ timing repair behavior.

Related

@jhkim-pii jhkim-pii self-assigned this Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .gitignore file to ignore .omo files and updates the tools/OpenROAD subproject commit to a newer version. I have no feedback to provide as there are no review comments.

@maliberty

Copy link
Copy Markdown
Member

Is this a no-merge PR?

@jhkim-pii jhkim-pii changed the title tools: Bump OpenROAD submodule (DO NOT MERGE) tools: Bump OpenROAD submodule Jul 8, 2026
@jhkim-pii

Copy link
Copy Markdown
Contributor Author

Is this a no-merge PR?

Yes. This PR is to check the ORFS design QoR impact.
There is no QoR change, so I close this.

@jhkim-pii jhkim-pii closed this Jul 8, 2026
@jhkim-pii jhkim-pii changed the title (DO NOT MERGE) tools: Bump OpenROAD submodule (DO NOT MERGE) ORFS QoR check for latch D-input path optimization Jul 8, 2026
Update the OpenROAD submodule to the RSZ latch time-borrow repair branch without the OpenSTA submodule update.

This keeps the ORFS PR focused on the RSZ fix and avoids carrying the unrelated STA update commit.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii jhkim-pii reopened this Jul 8, 2026
@openroad-ci openroad-ci force-pushed the secure-rsz-time-borrow-opt branch from b8837d3 to 2965a47 Compare July 8, 2026 05:11
jhkim-pii added 4 commits July 8, 2026 19:59
Update the OpenROAD submodule to the RSZ latch time-borrow repair branch after merging latest master.

This restores the OpenSTA scene/mode object update required by ORFS save_images.tcl while keeping the RSZ time-borrow fixes on the branch.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Update only the metadata rules that failed in public PR-4339-merge build 4 after the OpenROAD submodule bump.

The new thresholds match the archived Jenkins metadata for nangate45/tinyRocket and sky130hd/microwatt so local metadata checks pass without changing unrelated rules.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Update the cts setup TNS rule that failed in public PR-4339-merge build 5 after the previous QoR rule update allowed the flow to progress further.

The updated threshold matches the archived Jenkins metadata for nangate45/mempool_group and leaves unrelated rules unchanged.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Merge the latest master branch into secure-rsz-time-borrow-opt to resolve QoR rules conflicts before public sync.

Keep the OpenROAD submodule on the RSZ time-borrow optimization commit while accepting the relaxed master QoR rule thresholds that cover the Jenkins metadata failures.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants