odb: make 3DBlox connection region check direction-aware#10840
Open
osamahammad21 wants to merge 1 commit into
Open
odb: make 3DBlox connection region check direction-aware#10840osamahammad21 wants to merge 1 commit into
osamahammad21 wants to merge 1 commit into
Conversation
Closes The-OpenROAD-Project#10836 Signed-off-by: osamahammad21 <osama@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the 3D-Blox connection validation logic by introducing a ConnectionStatus enum to provide more detailed error messages for invalid connections (such as invalid stacking direction, XY overlap, Z overlap, or thickness mismatch). It also updates dbUnfoldedBuilder to handle Z-mirroring of assemblies by swapping top and bottom regions when parent_xform.isMirrorZ() is true, and updates/adds corresponding unit tests. There are no review comments, so I have no feedback to provide.
maliberty
reviewed
Jul 8, 2026
Comment on lines
+205
to
207
| if (!top || !bot) { | ||
| return ConnectionStatus::kValid; | ||
| } |
Member
There was a problem hiding this comment.
Is it ok for chips to touch with no defined region?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
topregion must face down and the declaredbotregion must face upType of Change
Impact
check_3dbloxnow flags connections whosetop/botdeclaration contradicts the physical stackup; invalid-connection messages state the exact failure reasonVerification
./etc/Build.sh).Related Issues
Closes #10836