Cts: improve level creating threshold#10842
Draft
arthurjolo wants to merge 9 commits into
Draft
Conversation
…gion Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
…creation threshold Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the H-tree level creation stop criterion in CTS by using the actual sink region geometry, preventing shallow trees.
The existing stop criterion for H-tree level creation relied solely on the number of sinks per subregion (isNumberOfSinksTooSmall). This could cause the tree to stop building levels too early or too late, depending on sink distribution — particularly for designs with max_wirelength set or macro trees.
Type of Change
Impact
Combined H-tree level stop criterion: When max_wirelength is set, level creation now stops only when both the largest sink region HPWL is smaller than max_wirelength and the number of sinks per subregion is too small. Previously, the sink-count check alone could stop the tree prematurely when sinks were still geometrically spread out. When max_wirelength is not set, the original sink-count-only criterion is preserved.
Guard against invalid maxWl (TritonCTS.cpp:247-249): setMaxWl is now only called when resizer_->findMaxWireLength() returns a positive value, preventing a zero/negative max wirelength from disabling the geometric check
Verification
./etc/Build.sh).Related Issues