Migrate to Bazel 9#10845
Conversation
openroad-ci
force-pushed
the
bazel-9-migration
branch
from
24b2b5e to
090f82f
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the Bazel version from 8.6.0 to 9.1.1. To ensure compatibility with Bazel 9, which removed native C++ rules, several dependencies in MODULE.bazel have been updated or overridden to use versions that load these rules from @rules_cc. Specifically, rules_go is updated to 0.61.1, freetype is overridden to 2.13.3.bcr.2, spdlog is updated to 1.17.0, and scip is updated to 9.2.3.bcr.1. Additionally, the BAZEL_ORFS_COMMIT has been updated. There are no review comments, so I have no feedback to provide.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bazel 9 removes several long-deprecated globals and native rules (CcInfo, cc_test, cc_library/cc_binary, sh_binary). Update or pin the dependencies whose .bzl/BUILD files still used the removed forms: - rules_go: force 0.61.1. The MVS-selected 0.53.0 (transitive via or-tools, gazelle, grpc-java, aspect_rules_lint -> rules_buf) referenced the removed CcInfo global in cgo.bzl; 0.59.0+ loads it from @rules_cc. - spdlog: 1.15.1 -> 1.17.0. Its BUILD.bazel used the native cc_test. - scip: 9.2.3 -> 9.2.3.bcr.1. The overlay used native cc_library/ cc_binary; .bcr.1 loads them from @rules_cc (same source, so the tinycthread patch still applies). - freetype: 2.13.3 -> 2.13.3.bcr.2 (transitive via qt-bazel -> harfbuzz). The overlay used native cc_library; .bcr.2 loads it from @rules_cc (same 2.13.3 source). - bazel-orfs: bump to 551d4c7. Its generated mock_klayout BUILD loads sh_binary from @rules_shell, and its generated gnumake BUILD overlay loads cc_binary from @rules_cc -- both native rules Bazel 9 removed (upstream PRs The-OpenROAD-Project#759 and The-OpenROAD-Project#761). Also suppress -Wc++11-narrowing in third-party/mockturtle's emap test: its vendored headers narrow ints in braced initializer lists, which clang treats as an error by default. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
openroad-ci
force-pushed
the
bazel-9-migration
branch
from
090f82f to
74c09a5
Compare
1 participant
Bazel 9 removes several long-deprecated globals and native rules (CcInfo, cc_test, cc_library/cc_binary, sh_binary). Update or pin the dependencies whose .bzl/BUILD files still used the removed forms:
harfbuzz). The overlay used native cc_library; .bcr.2 loads it from @rules_cc (same 2.13.3 source).
runTritonCTSsegment failed in gtest #761).