coverity and tag and scene doc#386
Merged
maliberty merged 1 commit intoJul 8, 2026
Merged
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive documentation file doc/TagsAndScenes.md explaining the concepts of Tags, Scenes, and Timing Propagation in the Scene-based fork of OpenSTA. Additionally, it updates a unit test in TestSearchStaDesign.cc to assert that the searchThru predicate is pure and stable across multiple calls. There are no review comments to address, and I have no further feedback to provide.
maliberty
approved these changes
Jul 8, 2026
Member
|
It would be nice to have a section on how threading is handled. There are a lot of global structures here - are they locked, pre-populated, etc? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverity fix, and one document outlining Tag usage in OpenSTA