Skip to content

borked the logic on stop if nots in previous PR#118

Merged
tomjemmett merged 2 commits into
mainfrom
fix_filters
May 13, 2026
Merged

borked the logic on stop if nots in previous PR#118
tomjemmett merged 2 commits into
mainfrom
fix_filters

Conversation

@tomjemmett

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 13, 2026 13:31
@tomjemmett tomjemmett requested a review from francisbarton as a code owner May 13, 2026 13:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes broken stopifnot() argument validation in read_azure_table() so that invalid filter, select, and top inputs correctly trigger errors instead of failing due to mis-specified stopifnot() expressions.

Changes:

  • Corrected stopifnot() usage for filter and select validation.
  • Corrected stopifnot() usage for top validation (numeric / length-1 / positive).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/read_azure_table.R
@tomjemmett tomjemmett merged commit 41ed4da into main May 13, 2026
1 check passed
@tomjemmett tomjemmett deleted the fix_filters branch May 14, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants