Refactor Alphabetical implementation and tests#7370
Open
felseje wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Refactor Alphabetical implementation and tests#7370felseje wants to merge 2 commits intoTheAlgorithms:masterfrom
felseje wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7370 +/- ##
============================================
- Coverage 79.51% 79.51% -0.01%
- Complexity 7142 7143 +1
============================================
Files 796 796
Lines 23359 23365 +6
Branches 4596 4596
============================================
+ Hits 18575 18579 +4
- Misses 4046 4047 +1
- Partials 738 739 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felseje
force-pushed
the
refactor/alphabetical
branch
2 times, most recently
from
6810050 to
09c3007
Compare
felseje
force-pushed
the
refactor/alphabetical
branch
from
09c3007 to
741afcb
Compare
Author
|
Regarding the SpotBugs warning (NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION), this appears to be a false positive. |
Replaced boolean literals with Boolean.TRUE/FALSE in Arguments.of(...) to avoid SpotBugs warning (NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION). This is a false positive caused by JUnit's Object... varargs requiring auto-boxing.
felseje
force-pushed
the
refactor/alphabetical
branch
from
dd977de to
3e1e980
Compare
felseje
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Author
|
PR moved out of draft and all checks are now passing. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Alphabetical implementation to clarify its behavior and improve consistency between code and tests.
Changes include:
No functional change in intended behavior.
clang-format -i --style=file path/to/your/file.java