Skip to content

Prevent custom tick threads from blocking shutdown #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Txaverria wants to merge 1 commit into
base: multiversion-attempt
Choose a base branch
from
+10 −1
Open

Prevent custom tick threads from blocking shutdown #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion api/src/main/java/mods/thecomputerizer/theimpossiblelibrary/api/util/CustomTick.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,27 @@
import java.util.List;
import java.util.Objects;
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicInteger;

import static java.util.concurrent.TimeUnit.MILLISECONDS;

@SuppressWarnings("unused") @Getter
public class CustomTick {

private static final List<CustomTick> registeredTickEvents = new ArrayList<>();
private static final AtomicInteger threadCounter = new AtomicInteger();
private static final ThreadFactory threadFactory = runnable -> {
Thread thread = new Thread(runnable,"TIL-CustomTick-"+threadCounter.incrementAndGet());
// Custom ticks live for the process lifetime and must not prevent the JVM from shutting down.
thread.setDaemon(true);
return thread;
};

private static void addCustomTick(final CustomTick ticker) {
CommonEventsAPI api = EventHelper.getEventsAPI(false,false);
if(Objects.isNull(api) || isRegistered(ticker)) return;
Executors.newScheduledThreadPool(1).scheduleAtFixedRate(() -> {
Executors.newScheduledThreadPool(1,threadFactory).scheduleAtFixedRate(() -> {
try {
api.postCustomTick(ticker);
} catch(Throwable t) {
Expand Down