Fix missing metadata.source_kind in exported JSON (#15)#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #15
Root Cause
The graph is built with
NewOpenGraph("KeyCredentialBase"), which records the source kind, but it was serialized viaog.ExportJSON(false). The boolean argument isincludeMetadata; when false,OpenGraph.ExportJSONskips writing the top-levelmetadataobject entirely. As a result every artifact was produced without themetadata.source_kindblock that BloodHound uses to scope ingests.Fix Description
Call
og.ExportJSON(true)so the serializer emits themetadatasibling ofgraphwith"source_kind": "KeyCredentialBase". This is the minimal change that restores the documented output shape; the rest of the export path is unchanged.How Verified
Static: with
includeMetadata == true, the guarded block atgopengraph/OpenGraph.go:577writesgraphData["metadata"] = {"source_kind": g.sourceKind}, andg.sourceKindis"KeyCredentialBase"fromNewOpenGraph.go build ./...andgo vet ./...pass.Test Coverage
None: exercising the full export requires a live LDAP/AD target to populate the graph; the changed line is a one-argument flag whose downstream behavior is covered by gopengraph's own export tests.
Scope of Change
main.go