Use KindKeyCredentialBase constant for source kind (#21)#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #21
Note
Maintainability/consistency cleanup, not a behavioral bug — included at the maintainer's explicit request. Output is byte-for-byte unchanged.
Root Cause
The source kind was declared twice: as the
KindKeyCredentialBaseconstant inkinds.goand again as a string literal"KeyCredentialBase"passed togopengraph.NewOpenGraphinmain.go. The constant was never referenced, so it was dead code and the two declarations could drift apart over time.Fix Description
Pass
KindKeyCredentialBasetoNewOpenGraphso the source kind has a single authoritative definition. Value is identical to the previous literal, so the generated graph is unchanged.How Verified
Static:
KindKeyCredentialBase == "KeyCredentialBase"(kinds.go:4), so the argument toNewOpenGraphis unchanged at runtime.go build ./...andgo vet ./...pass.Test Coverage
None: no behavioral change to test; the substitution is a compile-time constant equal to the prior literal.
Scope of Change
main.go