refactor(ini): Simplify token related INI code

[Caball009]

A handful of miscellaneous changes to the INI code. Should have zero change in behavior.

Generals and Zero Hour code are not separated, but the commit diffs are pretty clean.

[greptile-apps]

Greptile Summary

This PR refactors the INI parsing class for cleanliness and consistency: it converts separator and token accessor methods from instance methods backed by member fields to inline static methods returning string literals, makes getNextToken/getNextTokenOrNull/getNextSubToken static (they already only used global strtok state), removes the trivial empty destructor, and tidies call-sites across both Generals/ and GeneralsMD/ trees (normalising token != nullptr → token, while-loops to for-loops, and replacing getNextTokenOrNull+null-check patterns with getNextToken). The PR author states zero behavioral change, and review confirms this — all comparisons of getEndToken() ("End" vs the old "END") remain via stricmp, and the CPP_11(= delete) macro addresses the earlier copy-protection concern.

Confidence Score: 5/5

This PR is safe to merge — all changes are zero-behavior refactoring with no new logic or data-flow introduced.

Every change is a mechanical cleanup: member separator fields replaced by static inline methods returning the same string literals, trivial empty destructor removed, getNextToken/OrNull/SubToken made static (they already only used global strtok state), and loop-condition style harmonised. The copy-protection concern from a prior review thread is properly addressed via CPP_11(= delete). No P0 or P1 findings remain.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/Common/INI.h	Core INI class header: separator fields removed and replaced with static inline methods; copy/assignment protected via CPP_11(= delete); getNextToken/getNextTokenOrNull/getNextSubToken made static; trivial destructor declaration removed.
Core/GameEngine/Source/Common/INI/INI.cpp	INI.cpp: constructor no longer initialises removed separator members; empty destructor body removed; null-seps guard removed from getNextToken/getNextTokenOrNull; parseSoundsList converted to constexpr + for-loop; minor token != nullptr → token cleanup throughout.
Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp	parseDebrisObjectNames: variable renamed from debrisName to token; pre-existing double-advance preserved (acknowledged, separate PR incoming).
Generals/Code/GameEngine/Source/GameLogic/Object/Update/AutoDepositUpdate.cpp	parseUpgradePair: getNextTokenOrNull+manual null-check replaced with getNextToken (which throws on null — same exception type, equivalent behavior).
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/OCLUpdate.cpp	parseFactionObjectCreationList: same getNextTokenOrNull+null-check → getNextToken refactor as AutoDepositUpdate.
Generals/Code/GameEngine/Include/Common/BitFlagsIO.h	BitFlags::parse: token != nullptr → token in loop condition, no functional change.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class INI {
        -INI(const INI&) = delete
        -INI& operator=(const INI&) = delete
        +INI()
        +isEOF() bool
        +getFilename() AsciiString
        +getLoadType() INILoadType
        +getLineNum() UnsignedInt
        +getSeps()$ const char*
        +getSepsPercent()$ const char*
        +getSepsColon()$ const char*
        +getSepsQuote()$ const char*
        +getEndToken()$ const char*
        +getNextToken(seps)$ const char*
        +getNextTokenOrNull(seps)$ const char*
        +getNextSubToken(expected)$ const char*
        +initFromINI(what, parseTable) void
        +initFromINIMulti(what, parseTableList) void
        -m_readBuffer char*
        -m_readBufferUsed unsigned
        -m_filename AsciiString
        -m_loadType INILoadType
        -m_lineNum UnsignedInt
        -m_buffer char[]
        -m_endOfFile Bool
    }
    note for INI "Separator strings removed as member fields;\nnow returned by static inline methods.\ngetNextToken/OrNull/SubToken also made static."

Loading

_{Reviews (5): Last reviewed commit: "Merge branch 'main' into ini_small_refac..." | Re-trigger Greptile}

[xezon]

Needs rebase.

[xezon]

Looks stable