fix: use config class loader, then context class loader, then parent in GIZMO#2284
Open
Christopher-Chianelli wants to merge 2 commits intoTimefoldAI:mainfrom
Open
fix: use config class loader, then context class loader, then parent in GIZMO#2284Christopher-Chianelli wants to merge 2 commits intoTimefoldAI:mainfrom
Christopher-Chianelli wants to merge 2 commits intoTimefoldAI:mainfrom
Conversation
…in GIZMO Co-authored-by: Jan Willem Keizer <janwillemkeizer@gmail.com>
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the thread local solution is ugly, but I don't see another way of passing this required data to where it needs to be without a massive refactoring of everything.
The test basically copies the existing
TestdataObject,TestdataEntity,TestdataValueandTestdataSolutionclass into a new class loader, and can reproduce the exception when the solver config's classloader is not set.Fixes #2264