feat(core): parse UdtStructV0 struct metadata from contract spec WASM - #400
Merged
Merged
Conversation
Extract named struct fields from contractspecv0 so return values can be decoded as labeled JSON, with bounded XDR and type-depth limits so cyclic or hostile specs cannot stack-overflow the parser.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The main merge dropped the helpers that decoder.rs still calls, which broke CI with E0433/E0425.
Restore struct-name tracking after the main merge left seen_structs unused, which made rustc fail with E0282 on CI.
codeZe-us
self-requested a review
August 22, 2026 18:51
codeZe-us
approved these changes
Aug 22, 2026
codeZe-us
left a comment
Contributor
There was a problem hiding this comment.
@Agbasimere PR reviewed and merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScSpecEntry::UdtStructV0fromcontractspecv0into cacheableContractStructDefentries onContractSpec(name, fields,ScSpecTypeDef).Test plan
cargo test -p grat-core --lib spec::(27 passed)cargo fmt --all -- --check(currently fails on pre-existing files outside this change)cargo test --workspace --all-targets --all-featureson Ubuntu CI (local MSVC SDK is missingkernel32.lib;multi_op_decoderalso does not compile against stellar-xdr 21)Closes: #395