Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
ToothlessGear
/
node-gcm
Public
Notifications
You must be signed in to change notification settings
Fork
201
Star
1.3k
Code
Issues
26
Pull requests
10
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
V1 no send no retry
- #248
#248
Merged
hypesystem
merged 22 commits into
v1
ToothlessGear/node-gcm:v1
from
v1-no-send-no-retry
ToothlessGear/node-gcm:v1-no-send-no-retry
Copy head branch name to clipboard
Jun 9, 2016
Conversation
Commits
22
(22)
Checks
Files changed
Merged
V1 no send no retry
#248
hypesystem
merged 22 commits into
v1
ToothlessGear/node-gcm:v1
from
v1-no-send-no-retry
ToothlessGear/node-gcm:v1-no-send-no-retry
Copy head branch name to clipboard
Commits
Commits on Jun 1, 2016
Remove sendNoRetry from being exposed
hypesystem
committed
22a07f3
View commit details
Copy full SHA for 22a07f3
Browse repository at this point
Rename sendNoRetry -> sendMessage
hypesystem
committed
3d8b4f6
View commit details
Copy full SHA for 3d8b4f6
Browse repository at this point
Remove unnecessary support for no callback (always called with callback!)
hypesystem
committed
81c27c3
View commit details
Copy full SHA for 81c27c3
Browse repository at this point
Commits on Jun 2, 2016
Rewrite sendNoRetry tests to use send with retries: 0
hypesystem
committed
3d18769
View commit details
Copy full SHA for 3d18769
Browse repository at this point
Extract sendMessageWithRetries function
hypesystem
committed
0e6d133
View commit details
Copy full SHA for 0e6d133
Browse repository at this point
Modify retry to use sendMessageWithRetries
hypesystem
committed
008e2fd
View commit details
Copy full SHA for 008e2fd
Browse repository at this point
Added a note about a case that seems odd
hypesystem
committed
cf7b494
View commit details
Copy full SHA for cf7b494
Browse repository at this point
Remove self argument from retry and sendMessageWithRetries
hypesystem
committed
0236fbf
View commit details
Copy full SHA for 0236fbf
Browse repository at this point
Get request body early on, simply pass it through
hypesystem
committed
d125924
View commit details
Copy full SHA for d125924
Browse repository at this point
fix indentation
hypesystem
committed
d4eec16
View commit details
Copy full SHA for d4eec16
Browse repository at this point
Build requestOptions early and pass around (instead of building for each request!
hypesystem
committed
d174ce7
View commit details
Copy full SHA for d174ce7
Browse repository at this point
Reorder functions
hypesystem
committed
e177346
View commit details
Copy full SHA for e177346
Browse repository at this point
Remove an irrelevant return
hypesystem
committed
c558a7c
View commit details
Copy full SHA for c558a7c
Browse repository at this point
Removed redundant tests (now covered by send with retries: 0)
hypesystem
committed
7a0e08e
View commit details
Copy full SHA for 7a0e08e
Browse repository at this point
Dont try to mock sendNoRetry
hypesystem
committed
e0a6969
View commit details
Copy full SHA for e0a6969
Browse repository at this point
Removed some more redundant tests
hypesystem
committed
e8dd0ff
View commit details
Copy full SHA for e8dd0ff
Browse repository at this point
Make all send specs async
hypesystem
committed
9c32fb2
View commit details
Copy full SHA for 9c32fb2
Browse repository at this point
Commits on Jun 8, 2016
Break out of retry if there are no retries left!
hypesystem
committed
79873f8
View commit details
Copy full SHA for 79873f8
Browse repository at this point
Remove this one weird case that is good for naught
hypesystem
committed
20fad62
View commit details
Copy full SHA for 20fad62
Browse repository at this point
Make send() tests work.
Show description for 41b2d94
hypesystem
committed
41b2d94
View commit details
Copy full SHA for 41b2d94
Browse repository at this point
merge two tests, so the same on now tests sender options and auth key
hypesystem
committed
a1343eb
View commit details
Copy full SHA for a1343eb
Browse repository at this point
Remove two tests that no longer pass (and shouldnt!)
Show description for 7e55699
hypesystem
committed
7e55699
View commit details
Copy full SHA for 7e55699
Browse repository at this point
You can’t perform that action at this time.