refactor(workspaces): drop CLI-pick checkboxes from create flow#215
Merged
Conversation
Three workspace-create surfaces (sidebar quick-create, chat-section inline form, template detail page spawn form) each carried a row of checkboxes asking the user to pick which CLI adapters (claude / codex / shell) to enable. Two problems: - Default was wrong — template-registry's fallback is `['claude']`, so any template that didn't explicitly opt in shipped a "half-on" workspace by default. auto-quant was exactly this case. - Position was wrong — picking adapters is a configuration decision the user has no judgement basis for at first-action time. It also paved over the bad default by making it "the user's fault" if they didn't tick more boxes. Remove the checkbox row from all three surfaces. Every workspace now gets every available adapter enabled. The template's `defaultAgents` field still drives `agents[0]` (= "+ new session" default adapter) + the TemplateCard badges, so template authors retain steering over the common case. Three surfaces had also drifted into three copies of the same tag-validation + agent-resolution + create-API logic. Extracted to `useCreateWorkspace` hook so they stay in lockstep. - auto-quant template defaults bumped to [claude, codex] for parity with chat / finance-research. The frontend would enable both anyway, but keeps the agents[0] semantic honest if a future template ever wants to reach back to "only claude on +". - Template README "Parameters" sections updated — they were describing the now-removed agent-picker UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three workspace-create surfaces (sidebar quick-create, Chat workspace section inline form, Template detail page spawn form) each carried a row of checkboxes asking the user to pick which CLI adapters (claude / codex / shell) to enable. Two problems:
template-registry's fallback is['claude'], so any template that didn't explicitly opt in shipped a "half-on" workspace.auto-quantwas exactly this case.Changes
useCreateWorkspacehook — the three surfaces had drifted into three copies of the same tag-validation + agent-resolution + create-API logicdefaultAgentsfield still drivesagents[0](= "+ new session" default adapter) + TemplateCard badges, so template authors retain steering over the common caseauto-quanttemplate defaults bumped to[claude, codex]for parity with chat / finance-researchNet: +166 / −234.
Test plan
npx tsc --noEmitclean (Alice strict)npx tsc -bclean (UI strict)pnpm test— 1789/1789 passBoundary touch
None — UI + template metadata only. Backend
createWorkspaceAPI unchanged (still accepts anagentsarray; frontend just always sends the full set).Generated by Claude Code