test(http): wire MTConnect.NET-HTTP-Tests into the solution#187
Draft
ottobolyos wants to merge 1 commit into
Draft
test(http): wire MTConnect.NET-HTTP-Tests into the solution#187ottobolyos wants to merge 1 commit into
ottobolyos wants to merge 1 commit into
Conversation
ottobolyos
force-pushed
the
test/http-tests-sln-wireup
branch
2 times, most recently
from
f91c5a7 to
8414757
Compare
Restore the MTConnect.NET-Tests-Agents and MTConnect.NET-HTTP-Tests project entries to MTConnect.NET.sln, their build configurations for all four solution-wide configurations, and their SolutionFolders mapping under "Tests". Both projects were dropped from the solution in c6ac2bc (docs-gen) so dotnet build/test against the solution file no longer enumerates them; running tests against the project directories directly still worked but the solution-level CI sweep missed all 15 HTTP-Tests fixtures.
ottobolyos
force-pushed
the
test/http-tests-sln-wireup
branch
from
8414757 to
54d6252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/MTConnect.NET-HTTP-Tests/builds and passes when invoked directly viadotnet test tests/MTConnect.NET-HTTP-Tests, but it is not currently a project ofMTConnect.NET.slnon master, so the solution-level CI run does not exercise it. This PR adds the project (and its companionMTConnect.NET-Tests-Agentssupport project) to the solution so futuredotnet build MTConnect.NET.sln+dotnet test MTConnect.NET.slninvocations cover the 15 HTTP-Tests fixtures.Files changed
MTConnect.NET.sln— added theMTConnect.NET-Tests-AgentsandMTConnect.NET-HTTP-Testsproject entries, their build configurations for Debug / Docker / Package / Release, and the matchingSolutionFoldersmapping under "Tests".Verification
dotnet build MTConnect.NET.sln— green; the project enumeration now includes both new entries (0 warnings, 0 errors).dotnet test MTConnect.NET.sln --filter "Category!=E2E&Category!=RequiresDocker&Category!=XsdLoadStrict"— green; HTTP-Tests reportsPassed: 15, Total: 15in the solution-level sweep.