Skip to content

Refactor AppShell navigation and clean up route registration #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
May 25, 2026
Merged

Refactor AppShell navigation and clean up route registration #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion TransactionProcessor.Mobile/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ public App(IApplicationThemeService applicationThemeService)
RegisterRouteOnce(nameof(BillPaymentSuccessPage), typeof(BillPaymentSuccessPage));
RegisterRouteOnce(nameof(BillPaymentFailedPage), typeof(BillPaymentFailedPage));
RegisterRouteOnce(nameof(AdminPage), typeof(AdminPage));
//RegisterRouteOnce(nameof(LoginPage), typeof(LoginPage));

RegisterRouteOnce(nameof(ViewLogsPage), typeof(ViewLogsPage));

Expand Down
9 changes: 1 addition & 8 deletions TransactionProcessor.Mobile/AppShell.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public AppShell()
InitializeComponent();
}

protected override async void OnNavigating(ShellNavigatingEventArgs args)
protected override void OnNavigating(ShellNavigatingEventArgs args)
{
base.OnNavigating(args);
if (args.Source == ShellNavigationSource.ShellSectionChanged)
Expand All @@ -28,12 +28,5 @@ protected override async void OnNavigating(ShellNavigatingEventArgs args)
}
}
}

protected override void OnNavigated(ShellNavigatedEventArgs args)
{
//Logger.LogDebug($"In OnNavigated - Source [{args.Source.ToString()}] {JsonConvert.SerializeObject(args)}");

base.OnNavigated(args);
}
}
}
Loading