Handle null input in ConvertFrom by returning empty list#638
Merged
StuartFerguson merged 2 commits intoApr 8, 2026
Merged
Conversation
Changed ConvertFrom to return an empty list instead of null when the input model is null, improving null safety and consistency. Moved responses list initialization before the null check to support this behavior.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Changed ModelFactory_ConvertFrom test to assert that converting a null model returns an empty list (Count == 0) rather than null, reflecting updated method behavior.
github-actions
Bot
deleted the
bug/#622_return_an_empty_collection_instead_of_null
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ConvertFrom to return an empty list instead of null when the input model is null, improving null safety and consistency. Moved responses list initialization before the null check to support this behavior.
closes #622