Skip to content

Refactor ProcessSaleTransaction to use parameter tuples #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Apr 9, 2026
Merged

Refactor ProcessSaleTransaction to use parameter tuples #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d17464
Refactor ProcessSaleTransaction to use parameter tuples
StuartFerguson Apr 8, 2026
60b3791
Merge branch 'master' into refactor/#611_process_sale_txn_parameters
StuartFerguson Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions TransactionProcessorACL.BusinessLogic.Tests/MediatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,12 @@ public async Task<Result<ProcessLogonTransactionResponse>> ProcessLogonTransacti
String deviceIdentifier,
CancellationToken cancellationToken) => Result.Success(new ProcessLogonTransactionResponse());

public async Task<Result<ProcessSaleTransactionResponse>> ProcessSaleTransaction(Guid estateId,
Guid merchantId,
public async Task<Result<ProcessSaleTransactionResponse>> ProcessSaleTransaction((Guid estateId, Guid merchantId) merchantData,
DateTime transactionDateTime,
String transactionNumber,
String deviceIdentifier,
Guid operatorId,
String customerEmailAddress,
Guid contractId,
Guid productId,
(Guid operatorId, Guid contractId, Guid productId) productData,
Dictionary<String, String> additionalRequestMetadata,
CancellationToken cancellationToken) => Result.Success(new ProcessSaleTransactionResponse());

Expand Down
7 changes: 2 additions & 5 deletions TransactionProcessorACL.BusinessLogic.Tests/RequestHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,12 @@ public async Task ProcessSaleTransactionRequestHandler_Handle_RequestIsHandled()
{
Mock<ITransactionProcessorACLApplicationService> applicationService = new Mock<ITransactionProcessorACLApplicationService>();
applicationService
.Setup(a => a.ProcessSaleTransaction(It.IsAny<Guid>(),
It.IsAny<Guid>(),
.Setup(a => a.ProcessSaleTransaction(It.IsAny<(Guid, Guid)>(),
It.IsAny<DateTime>(),
It.IsAny<String>(),
It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<String>(),
It.IsAny<Guid>(),
It.IsAny<Guid>(),
It.IsAny<(Guid, Guid, Guid)>(),
It.IsAny<Dictionary<String,String>>(),
It.IsAny<CancellationToken>())).ReturnsAsync(TestData.ProcessSaleTransactionResponse);

Expand Down
37 changes: 11 additions & 26 deletions ...sactionProcessorACL.BusinessLogic.Tests/TransactionProcessorACLApplicationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,12 @@ public async Task TransactionProcessorACLApplicationService_ProcessSaleTransacti
.ReturnsAsync(TestData.SerialisedMessageResponseSale);
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction(TestData.EstateId,
TestData.MerchantId,
TestData.TransactionDateTime,
Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction((TestData.EstateId, TestData.MerchantId),
TestData.TransactionDateTime,
TestData.TransactionNumber,
TestData.DeviceIdentifier,
TestData.OperatorId,
TestData.CustomerEmailAddress,
TestData.ContractId,
TestData.ProductId,
(TestData.OperatorId, TestData.ContractId, TestData.ProductId),
TestData.AdditionalRequestMetadata,
CancellationToken.None);

Expand All @@ -193,15 +190,12 @@ public async Task TransactionProcessorACLApplicationService_ProcessSaleTransacti
.ReturnsAsync(TestData.SerialisedMessageResponseSale);
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction(TestData.EstateId,
TestData.MerchantId,
Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction((TestData.EstateId, TestData.MerchantId),
TestData.TransactionDateTime,
TestData.TransactionNumber,
TestData.DeviceIdentifier,
TestData.OperatorId,
TestData.CustomerEmailAddress,
TestData.ContractId,
TestData.ProductId,
(TestData.OperatorId, TestData.ContractId, TestData.ProductId),
TestData.AdditionalRequestMetadata,
CancellationToken.None);

Expand Down Expand Up @@ -235,15 +229,12 @@ public async Task TransactionProcessorACLApplicationService_ProcessSaleTransacti
{
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());

Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction(TestData.EstateId,
TestData.MerchantId,
Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction((TestData.EstateId, TestData.MerchantId),
TestData.TransactionDateTime,
TestData.TransactionNumber,
TestData.DeviceIdentifier,
TestData.OperatorId,
TestData.CustomerEmailAddress,
TestData.ContractId,
TestData.ProductId,
(TestData.OperatorId, TestData.ContractId, TestData.ProductId),
TestData.AdditionalRequestMetadata,
CancellationToken.None);

Expand All @@ -257,15 +248,12 @@ public async Task TransactionProcessorACLApplicationService_ProcessSaleTransacti
.ReturnsAsync(Result.Failure());
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction(TestData.EstateId,
TestData.MerchantId,
Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction((TestData.EstateId, TestData.MerchantId),
TestData.TransactionDateTime,
TestData.TransactionNumber,
TestData.DeviceIdentifier,
TestData.OperatorId,
TestData.CustomerEmailAddress,
TestData.ContractId,
TestData.ProductId,
(TestData.OperatorId, TestData.ContractId, TestData.ProductId),
TestData.AdditionalRequestMetadata,
CancellationToken.None);

Expand All @@ -279,15 +267,12 @@ public async Task TransactionProcessorACLApplicationService_ProcessSaleTransacti
.ThrowsAsync(new Exception("Error"));
securityServiceClient.Setup(s => s.GetToken(It.IsAny<String>(), It.IsAny<String>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.TokenResponse));

Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction(TestData.EstateId,
TestData.MerchantId,
Result<ProcessSaleTransactionResponse> result = await applicationService.ProcessSaleTransaction((TestData.EstateId, TestData.MerchantId),
TestData.TransactionDateTime,
TestData.TransactionNumber,
TestData.DeviceIdentifier,
TestData.OperatorId,
TestData.CustomerEmailAddress,
TestData.ContractId,
TestData.ProductId,
(TestData.OperatorId, TestData.ContractId, TestData.ProductId),
TestData.AdditionalRequestMetadata,
CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
Expand Down
7 changes: 2 additions & 5 deletions ...actionProcessorACL.BusinessLogic/RequestHandlers/ProcessLogonTransactionRequestHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,12 @@ public async Task<Result<ProcessReconciliationResponse>> Handle(TransactionComma
public async Task<Result<ProcessSaleTransactionResponse>> Handle(TransactionCommands.ProcessSaleTransactionCommand command,
CancellationToken cancellationToken)
{
return await this.ApplicationService.ProcessSaleTransaction(command.EstateId,
command.MerchantId,
return await this.ApplicationService.ProcessSaleTransaction((command.EstateId, command.MerchantId),
command.TransactionDateTime,
command.TransactionNumber,
command.DeviceIdentifier,
command.OperatorId,
command.CustomerEmailAddress,
command.ContractId,
command.ProductId,
(command.OperatorId, command.ContractId, command.ProductId),
command.AdditionalRequestMetadata,
cancellationToken);
}
Expand Down
18 changes: 7 additions & 11 deletions TransactionProcessorACL.BusinessLogic/Services/ITransactionProcessorACLApplicationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,13 @@ Task<Result<ProcessLogonTransactionResponse>> ProcessLogonTransaction(Guid estat
String deviceIdentifier,
CancellationToken cancellationToken);

Task<Result<ProcessSaleTransactionResponse>> ProcessSaleTransaction(Guid estateId,
Guid merchantId,
DateTime transactionDateTime,
String transactionNumber,
String deviceIdentifier,
Guid operatorId,
String customerEmailAddress,
Guid contractId,
Guid productId,
Dictionary<String,String> additionalRequestMetadata,
CancellationToken cancellationToken);
Task<Result<ProcessSaleTransactionResponse>> ProcessSaleTransaction((Guid estateId, Guid merchantId) merchantData,
DateTime transactionDateTime,
String transactionNumber,
String deviceIdentifier,
String customerEmailAddress,
(Guid operatorId, Guid contractId, Guid productId) productData,
Dictionary<String, String> additionalRequestMetadata, CancellationToken cancellationToken);

Task<Result<ProcessReconciliationResponse>> ProcessReconciliation(Guid estateId,
Guid merchantId,
Expand Down
Loading
Loading