Skip to content

Refactor BuildSaleTransactionRequest to use tuples #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Jun 16, 2026
Merged

Refactor BuildSaleTransactionRequest to use tuples #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions TransactionProcessorACL.BusinessLogic/Services/TransactionProcessorACLApplicationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,12 @@ public async Task<Result<ProcessSaleTransactionResponse>> ProcessSaleTransaction
Logger.LogWarning("Here 2.2");
TokenResponse accessToken = accessTokenResult.Data;

SaleTransactionRequest saleTransactionRequest = this.BuildSaleTransactionRequest(merchantData.estateId,
merchantData.merchantId,
SaleTransactionRequest saleTransactionRequest = this.BuildSaleTransactionRequest(merchantData,
transactionNumber,
deviceIdentifier,
transactionDateTime,
productData.operatorId,
productData,
customerEmailAddress,
productData.contractId,
productData.productId,
additionalRequestMetadata);

ProcessSaleTransactionResponse response = null;
Expand Down Expand Up @@ -169,15 +166,12 @@ private async Task<Result<TokenResponse>> GetAccessToken(CancellationToken cance
return await this.SecurityServiceClient.GetToken(clientId, clientSecret, cancellationToken);
}

private SaleTransactionRequest BuildSaleTransactionRequest(Guid estateId,
Guid merchantId,
private SaleTransactionRequest BuildSaleTransactionRequest((Guid estateId, Guid merchantId) merchantData,
String transactionNumber,
String deviceIdentifier,
DateTime transactionDateTime,
Guid operatorId,
(Guid operatorId, Guid contractId, Guid productId) productData,
String customerEmailAddress,
Guid contractId,
Guid productId,
Dictionary<String, String> additionalRequestMetadata)
{
return new SaleTransactionRequest
Expand All @@ -186,14 +180,14 @@ private SaleTransactionRequest BuildSaleTransactionRequest(Guid estateId,
DeviceIdentifier = deviceIdentifier,
TransactionDateTime = transactionDateTime,
TransactionType = "SALE",
OperatorId = operatorId,
OperatorId = productData.operatorId,
CustomerEmailAddress = customerEmailAddress,
TransactionSource = 1,
ContractId = contractId,
ProductId = productId,
ContractId = productData.contractId,
ProductId = productData.productId,
AdditionalTransactionMetadata = additionalRequestMetadata,
EstateId = estateId,
MerchantId = merchantId,
EstateId = merchantData.estateId,
MerchantId = merchantData.merchantId,
};
}

Expand Down
Loading