Skip to content

Add MerchantReportingId to MerchantResponse and tests #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Jul 7, 2026
Merged

Add MerchantReportingId to MerchantResponse and tests #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...sactionProcessorACL.BusinessLogic.Tests/TransactionProcessorACLApplicationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@ public async Task TransactionProcessorACLApplicationService_GetMerchant_Merchant
merchantResponse.IsSuccess.ShouldBeTrue();
merchantResponse.Data.ShouldNotBeNull();
merchantResponse.Data.MerchantId.ShouldBe(TestData.MerchantId);
merchantResponse.Data.MerchantReportingId.ShouldBe(TestData.MerchantReportingId);
merchantResponse.Data.Addresses.Count.ShouldBe(1);
merchantResponse.Data.Addresses[0].AddressLine1.ShouldBe(TestData.AddressLine1);
merchantResponse.Data.Addresses[0].Town.ShouldBe(TestData.Town);
Expand Down
1 change: 1 addition & 0 deletions TransactionProcessorACL.BusinessLogic/Services/ResponseFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public static class ResponseFactory
public static MerchantResponse Build(TransactionProcessor.DataTransferObjects.Responses.Merchant.MerchantResponse merchant) {
MerchantResponse merchantResponse = new() {
MerchantId = merchant.MerchantId,
MerchantReportingId = merchant.MerchantReportingId,
EstateId = merchant.EstateId,
MerchantName = merchant.MerchantName,
EstateReportingId = merchant.EstateReportingId,
Expand Down
1 change: 1 addition & 0 deletions TransactionProcessorACL.IntegrationTests/Shared/ACLSteps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ public async Task WhenIGetTheMerchantInformationForMerchantForEstateTheResponseS
MerchantResponse merchantResponse = StringSerialiser.Deserialise<MerchantResponse>(responseContent, new SerialiserOptions(SerialiserPropertyFormat.SnakeCase));
merchantResponse.ShouldNotBeNull();
merchantResponse.MerchantId.ShouldBe(merchantId);
merchantResponse.MerchantReportingId.ShouldNotBe(0);
merchantResponse.MerchantName.ShouldBe(expectedMerchantResponse.MerchantName);
merchantResponse.Addresses.ShouldNotBeNull();
merchantResponse.Addresses.Count.ShouldBe(1);
Expand Down
6 changes: 3 additions & 3 deletions TransactionProcessorACL.Testing/TestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@ public class TestData
TransactionNumber = TestData.TransactionNumber
};

/// <summary>
/// The merchant identifier
/// </summary>
public static Guid MerchantId = Guid.Parse("1C8354B7-B97A-46EA-9AD1-C43F33F7E3C3");

public static Int32 MerchantReportingId = 1;

public static RequestAuditContext RequestAuditContext = new RequestAuditContext(
RequestId: "req-123",
TraceId: "trace-123",
Expand Down Expand Up @@ -379,6 +378,7 @@ public static TransactionProcessor.DataTransferObjects.Responses.Merchant.Mercha
Contacts = new (){
Contact
},
MerchantReportingId = MerchantReportingId
};
public static List<TransactionProcessor.DataTransferObjects.Responses.Contract.ContractResponse> MerchantContractResponses(TransactionProcessor.DataTransferObjects.Responses.Contract.ProductType productType) =>
new() {
Expand Down
Loading