fix(test): add CI validation for test snapshots to prevent silent drift - #340
Merged
ALLEN-AYODEJI merged 1 commit intoAug 28, 2026
Conversation
- Add 'Validate test snapshots are up to date' step in contract-ci.yml: regenerates snapshots with SOROBAN_TEST_SNAPSHOT_FILE=overwrite then fails with a clear message if git diff detects any change. - Add 'test-snapshots-update' Makefile target so developers can regenerate snapshots locally before opening a PR. - Add Section 10 'Test Snapshots' to CONTRIBUTING.md explaining why snapshots are tracked, how to regenerate them, and what the CI check does; renumber subsequent sections 11-14 accordingly. - Add PR checklist item for snapshot regeneration to .github/PULL_REQUEST_TEMPLATE.md.
|
@samuel22x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #
Type of Change
Testing Done
Screenshots (if UI)
Checklist
See CONTRIBUTING.md for detailed guidelines. Commit messages should follow Conventional Commits format (e.g.
fix(infra): ...) since PRs are squash-merged.closes #144