Skip to content

Resolve remaining source-of-truth inconsistencies and add CI consistency checks - #7

Merged
techrebelgit merged 6 commits into
mainfrom
fix/issue-5-consistency
Sep 4, 2026
Merged

Resolve remaining source-of-truth inconsistencies and add CI consistency checks#7
techrebelgit merged 6 commits into
mainfrom
fix/issue-5-consistency

Conversation

@armandocodecr

Copy link
Copy Markdown
Contributor

Closes #5

Most of the issue's checkboxes were already resolved by #2, #3, and #4. This PR sweeps the whole repo for what remained and adds automated guardrails:

  • SKILL.md — install command and skills.sh link now use the canonical trustless-work/trustlesswork-skill naming.
  • skills/api/core-concepts.md — the transaction-flow example mixed networks (mainnet base URL + WalletNetwork.TESTNET); now consistently testnet with a mainnet comment.
  • skills/api/multi-release-escrow.mdcomplete-milestone was the last interface documenting milestoneIndex as number; now string like every other endpoint.
  • skills/api/types.mdapproverFunds / receiverFunds on the indexer response marked @deprecated (legacy two-party resolution model, superseded by distributions: { address, amount }[]).
  • skills/api/trustlines.md — the 0.5 XLM reserve is now described as a current Stellar network parameter, not a Trustless Work constant.
  • scripts/check-consistency.sh + CI workflow — 8 grep-based checks that fail the build if known regressions reappear: quoted numeric amounts, stale Authorization: Bearer, old repo names, numeric milestoneIndex (examples and API interfaces), deprecated stellar-sdk imports, tuple-style distributions, fee-as-funding-amount guidance, and claims that reads skip the API key. All checks pass on this branch.

Verified clean sweeps (no remaining hits) for the checkboxes closed by earlier PRs: API-key requirement on all endpoints, key security model, fees-at-release, lifecycle tagging, Bearer removal, resolve-dispute payload shape, trustline address scope, contract-verified role permissions, and the source-of-truth hierarchy.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4faeff86-d350-4ff3-aecc-e75178cb9d14


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@techrebelgit techrebelgit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge. We identified a few follow-up consistency gaps (Blocks API-key wording, tuple-style distributions example, stronger grep coverage, and clearer legacy indexer deprecation wording), but these can be addressed immediately after merge as follow-up fixes.

@techrebelgit
techrebelgit merged commit f179612 into main Sep 4, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit and reconcile skill source-of-truth inconsistencies

2 participants