Resolve remaining source-of-truth inconsistencies and add CI consistency checks - #7
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
techrebelgit
approved these changes
Sep 4, 2026
techrebelgit
left a comment
Contributor
There was a problem hiding this comment.
Approved to merge. We identified a few follow-up consistency gaps (Blocks API-key wording, tuple-style distributions example, stronger grep coverage, and clearer legacy indexer deprecation wording), but these can be addressed immediately after merge as follow-up fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Most of the issue's checkboxes were already resolved by #2, #3, and #4. This PR sweeps the whole repo for what remained and adds automated guardrails:
trustless-work/trustlesswork-skillnaming.WalletNetwork.TESTNET); now consistently testnet with a mainnet comment.complete-milestonewas the last interface documentingmilestoneIndexasnumber; nowstringlike every other endpoint.approverFunds/receiverFundson the indexer response marked@deprecated(legacy two-party resolution model, superseded bydistributions: { address, amount }[]).Authorization: Bearer, old repo names, numericmilestoneIndex(examples and API interfaces), deprecatedstellar-sdkimports, tuple-style distributions, fee-as-funding-amount guidance, and claims that reads skip the API key. All checks pass on this branch.Verified clean sweeps (no remaining hits) for the checkboxes closed by earlier PRs: API-key requirement on all endpoints, key security model, fees-at-release, lifecycle tagging, Bearer removal, resolve-dispute payload shape, trustline address scope, contract-verified role permissions, and the source-of-truth hierarchy.