Skip to content

Fix diving controls - #989

Closed
NHogweed wants to merge 3 commits into
Try:masterfrom
NHogweed:master
Closed

NHogweed wants to merge 3 commits into
Try:masterfrom
NHogweed:master

Conversation

@NHogweed

Copy link
Copy Markdown
Contributor

Forward/backward keys to control pitch and only jump key to move ahead, like in vanilla engine.

@Try Try left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @NHogweed !

I've checked Npc::walkMode vs Npc::isDive. There is an issue, that walkMode not accounting dive/water states, while this patch only hides the issue.

@NHogweed

Copy link
Copy Markdown
Contributor Author

this patch only hides the issue

Not sure what do you mean. Does an ordinary player complaining about underwater controls need anything more? Why it's so important to rely on walkMode here (and only here, unlike a couple of lines below)?

@Try

Try commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Not sure what do you mean.

You need to be careful with path you committing, and make sure that code you adding is something that make sense.
I think for now I'll take this PR, as a bug report rather, and will push a popper fix

@Try Try closed this Sep 16, 2026
Try added a commit that referenced this pull request Sep 16, 2026
@NHogweed

Copy link
Copy Markdown
Contributor Author

You need to be careful with path you committing

This was a reason why I decided to make changes as little as possible to achieve the stated goal and not to break anything else (that can be observed by a player). Anyway, your "philosophically and aestethically correct" fix is here, so there's no point to argue about that anymore. But there are still cosmetic problems with diving:

  • when the hero is upside down in the water, it is noticeable that his height rotation axis is out of his model;
  • rotation around height axis is not animated, unlike in vanilla game. The animation should be present when swimming as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants