Skip to content

princess: clean up old code#18

Merged
protitude merged 1 commit into
1.2.xfrom
md-1230
Apr 14, 2026
Merged

princess: clean up old code#18
protitude merged 1 commit into
1.2.xfrom
md-1230

Conversation

@protitude
Copy link
Copy Markdown
Collaborator

@protitude protitude commented Apr 13, 2026

Describe context / purpose for this PR

Retire princess

Issue link

#1230

Any other related PRs?

Link to MultiDev instance

http://md-1230-ucbsub-oit.pantheonsite.io

Checklist for PR author

  • I have checked that the PR is ready to be merged
  • I have reviewed the DIFF and checked that the changes are as expected
  • I have assigned myself or someone else to review the PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR retires the “princess” functionality by removing the associated Drush commands and dependency injection wiring from the OIT module, aligning with the goal of cleaning up old/unused code.

Changes:

  • Removed PrincessList dependency injection and related property from OitCommands.
  • Removed the oit:reload-princess and oit:load-princess Drush commands.
  • Updated drush.services.yml to stop injecting @servicenow.princess.list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Commands/OitCommands.php Drops PrincessList import/injection and removes the Princess-related Drush command methods.
drush.services.yml Removes the @servicenow.princess.list argument from the oit.commands Drush service definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@protitude protitude merged commit 02e74f4 into 1.2.x Apr 14, 2026
5 checks passed
@protitude protitude deleted the md-1230 branch April 14, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants