Feature/coastal multi frequency - #139
Open
sebastianrowan wants to merge 3 commits into
Open
Conversation
HenryGeorgist
left a comment
Contributor
There was a problem hiding this comment.
Create an interface called "FrequencyEvent" that has the methods for Frequency and SetFreqeuncy.
then we can have the same behavoir on any event as long as a hazard provider provides it. i like the pattern
| func (h CoastalFrequencyEvent) DV() float64 { | ||
| return -901.0 | ||
| } | ||
| func (h CoastalFrequencyEvent) Frequency() float64 { |
Contributor
There was a problem hiding this comment.
hmm. this is interesting. have you thought through how that works with a hazard provider?
Contributor
Author
There was a problem hiding this comment.
The hazard provider itself does not deal with the frequency. The hazard provider would provide a MultiFrequencyEvent which implements the HazardEvent interface (per your suggestion above it the MultiFrequencyEvent would implement the FrequencyEvent which would itself implement the HazardEvent).
…t and CoastalFrequencyEvent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HenryGeorgist two patterns here for implementing multi-frequency hazard. The coastal version here puts the frequency on the individual CoastalEvents and accesses the values through a Frequency() method. The version on the DepthEvent stores the frequencies as a slice in the MultiFrequencyDepth event.
Preference?