Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to eliminate having to periodically check the GCP Cloud Run Jobs tab to make sure no jobs have failed. By adding Sentry we will be able to see errors from the GCP runners and have them ping the Discord.
Prior to merge, both dev and prod secrets in GCP need to be updated to include the below:
The secrets must be updated independently as they are different (have different
MONGODB_URIs etc.)Since the
SENTRY_DSNvariable will only be specified on production, we should only get errors from production. I've added a new Sentry project for API Tools and added it to the existing alert that pings the Discord channel when there is a new error. I felt that alert only sent a ping when there was a new issue, but not a new event (single instance of an issue) but that's not how it seems to be set up so we'll have to see.I couldn't figure out how to add the Sentry go package without so many go.mod and go.sum changes. I tried
go get github.com/getsentry/sentry-gobut then when I ranbuild.batthe package got moved up into the first require block in go.mod, and a bunch of other things changed. Lmk how I can best resolve this.