Connectivity benchmarks #1549
Open
cmdupuis3 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for basic connectivity routines.
Helps with Issue #1196
Overview
This PR adds benchmarks for the pairwise connectivity routines (face, edge, node). Two of the nine are apparently unimplemented and are included as TODOs: node/node and edge/edge. We can delete them if they don't make sense.
Expected Usage
Waiting for merge to see real timings on larger grids on Glade, the smaller ones may be too small to sample reliably.
Run benchmarks with asv:
asv run --python=same --bench "bench_connectivity.Connectivity"PR Checklist
General
Testing
Documentation
_) and have been added todocs/internal_api/index.rstdocs/user_api/index.rst