fix(apollo-vertex): gate group membership via checkGroupMembership - #1095
fix(apollo-vertex): gate group membership via checkGroupMembership#1095frankkluijtmans wants to merge 1 commit into
Conversation
|
Apollo Coded App preview deployments are ready.
|
There was a problem hiding this comment.
Pull request overview
Updates the apollo-vertex group-membership gate to use @uipath/vs-core’s server-side checkGroupMembership endpoint (supports transitive/AAD-inherited membership) instead of enumerating groupMembers and matching by email.
Changes:
- Replaced the
useIsGroupMemberimplementation to query membership viacheckGroupMembership(userId, groupIds)using@tanstack/react-query. - Extended the local
@uipath/vs-coreoptional dependency type stub to includecheckGroupMembership.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/apollo-vertex/types/optional-deps.d.ts | Adds a typed checkGroupMembership API entry to the vs-core stub. |
| apps/apollo-vertex/registry/shell/use-is-group-member.ts | Switches membership resolution to a server-side membership check via React Query and userId. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| queryFn: (): Promise<Record<string, boolean>> => | ||
| checkGroupMembership && userId | ||
| ? checkGroupMembership(userId, groupIds) | ||
| : Promise.resolve({}), |
Dependency License Review
License distribution
Excluded packages
|
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
Storybook visual diff✅ No stories are affected by this PR's changes; nothing to compare. Logs Updated (PT): Aug 27, 2026, 09:47:40 AM |
Reworks the group-membership gate (
useIsGroupMember) to resolve membership through vs-core'scheckGroupMembership(one server-side call) instead of enumerating the fullgroupMemberscollection and matching users by email. This fixes AAD customers whose members are inherited via an assigned Azure AD group being wrongly denied, since the check endpoint resolves membership transitively. It also removes the brittle client-side email matching (and its null-email crash risk), fails closed when the check is unavailable, and adds thecheckGroupMembershiptype to the vs-core stub.👨 Generated with Kluijt Code