chore: normalize CRLF line endings in 5 testcase/script files - #1892
Merged
Conversation
TeodorEscuUiPath
requested review from
radu-mocanu
and
a lite review from Copilot
September 10, 2026 07:43
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues; changes are limited to verified line-ending normalization.
Pull request overview
This pull request normalizes CRLF to LF in five test and script files without changing content or behavior.
Changes:
- Converted four Python files and one JSON fixture to LF line endings.
- Prevented spurious Git modifications with
core.autocrlf=true. - Verified content is unchanged apart from line endings.
File summaries
| File | Change |
|---|---|
packages/uipath/testcases/langchain-cross/expected_traces.json |
Normalized line endings |
packages/uipath/testcases/common/trace_assert.py |
Normalized line endings |
packages/uipath/testcases/basic-testcase/src/assert.py |
Normalized line endings |
packages/uipath/testcases/apicalls-testcase/src/assert.py |
Normalized line endings |
packages/uipath/scripts/debug_test.py |
Normalized line endings |
Review details
Copilot wasn't able to review any files in this pull request.
- Files reviewed: 0/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Let's also add this in * text=auto
*.py text eol=lf
*.json text eol=lf
*.yaml text eol=lf
*.yml text eol=lf
*.toml text eol=lfThen we could run This PR can be the one-time normalization for the files that already slipped through. |
These files were committed with raw CRLF baked into the blob (from 120384a), which desyncs with core.autocrlf=true's LF-normalized storage assumption -- git status/diff reported them as modified even though the checked-out bytes were identical to HEAD. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… files Per Radu's review comment: pin text=auto plus eol=lf for py/json/yaml/yml/toml so committed line endings can't drift again, then renormalize the 6 more files (found via a repo-wide blob scan) that had the same CRLF-baked-into-blob issue as the original 5 but weren't surfaced by plain git status without a matching gitattributes/text-attribute rule in place. Content-only line-ending change, verified identical to HEAD with line endings stripped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
radu-mocanu
force-pushed
the
chore/fix-crlf-line-endings
branch
from
September 10, 2026 15:20
5e02516 to
f05d6ed
Compare
|
radu-mocanu
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
120384a2(the uipath-core/uipath-platform monorepo consolidation).core.autocrlf=true, Git's status/diff assumes LF-normalized storage; these files' stored CRLF desynced from that assumption, sogit statusreported them as modified on every fresh checkout even though the checked-out bytes were byte-for-byte identical toHEAD.IDENTICALfor all 5 files. Pure whitespace/line-ending normalization, no code or content change.Files:
packages/uipath/scripts/debug_test.pypackages/uipath/testcases/apicalls-testcase/src/assert.pypackages/uipath/testcases/basic-testcase/src/assert.pypackages/uipath/testcases/common/trace_assert.pypackages/uipath/testcases/langchain-cross/expected_traces.jsonTagging @radu-mocanu since these files trace back to their commit (
120384a2) for a quick sanity check.Test plan
git statusclean on a fresh checkout of this branch (no spurious CRLF diffs)🤖 Generated with Claude Code