Skip to content

Change logic when formatting job is running #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
todi1856 merged 1 commit into from
Sep 23, 2026
Merged

Change logic when formatting job is running #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .yamato/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ check_formatting:
- git clone --branch stable git@github.cds.internal.unity3d.com:unity/unity-meta.git --no-checkout
- git -C unity-meta checkout 6f6dd71b42f7fd3294032a6c89b1402ef3e46099
- perl unity-meta/Tools/Format/format.pl --dry-run com.unity.mobile.android-logcat/Editor com.unity.mobile.android-logcat/Tests TestProjects
triggers:
branches:
only:
- "/.*/"
1 change: 1 addition & 0 deletions .yamato/upm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ test_all_trigger:
only:
- "master"
dependencies:
- .yamato/format.yml#check_formatting
- .yamato/wrench/package-pack-jobs.yml#package_pack_-_mobile_android-logcat
{% for editor in test_editors %}
- .yamato/upm-integration-ci.yml#test_integration_{{ editor.version }}
Expand Down
2 changes: 0 additions & 2 deletions .yamato/wrench/package-pack-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ package_pack_-_mobile_android-logcat:
packages:
paths:
- upm-ci~/packages/**/*
dependencies:
- path: .yamato/format.yml#check_formatting
variables:
UPMCI_ACK_LARGE_PACKAGE: 1
WRENCH_LOCALAPV_URL: https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-3-18_814805bc36916a15e7c4fffd9156635086c96203ca783d5e2fb2e47f160d4eca.zip
Expand Down
7 changes: 0 additions & 7 deletions Tools/CI/Settings/UnityMobileLogcatSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ public class UnityMobileLogcatSettings : AnnotatedSettingsBase
{
IsReleasing = true
},
PackJobOptions = new PackJobOptions()
{
Dependencies = new List<Dependency>()
{
new("format", "check_formatting")
}
},
CustomChecks = new HashSet<Dependency>()
{
new Dependency("upm-ci", "test_all_trigger")
Expand Down
Loading