Skip to content

Fix Open Terminal - #225

Open
todi1856 wants to merge 3 commits into
masterfrom
fix-open-terminal
Open

todi1856 wants to merge 3 commits into
masterfrom
fix-open-terminal

Conversation

@todi1856

@todi1856 todi1856 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Yamato CI

Open Terminal is fixed now on:

2026-09-25.16-49-46.mp4

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The change adds Linux terminal launching and adjusts Windows launching, but the Linux path mishandles some valid launcher settings and SDK directory names.

Reviewed commit c7443a9

🤖 Helpful? 👍/👎

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatUtilities.cs Outdated
Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatUtilities.cs Outdated
@todi1856
todi1856 requested a review from IGuscin September 25, 2026 13:56
- Split $TERMINAL into executable and arguments without invoking a shell,
  so values like 'wezterm start' work.
- Pass the working directory as separate arguments via
  ProcessStartInfo.ArgumentList instead of embedding it in a quoted
  Arguments string, so paths containing quotes are preserved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@todi1856

Copy link
Copy Markdown
Member Author

/review

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The change adds Linux terminal support and updates Windows launching, with one reachable failure in the Linux terminal selection path.

Reviewed commit 7b60fdd

🤖 Helpful? 👍/👎

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatUtilities.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant