ci: pin the SDK checkout to the declared ucp-sdk version - #100
Merged
damaz91 merged 1 commit intoSep 7, 2026
Merged
Conversation
ptiper
approved these changes
Sep 4, 2026
pyproject.toml declares ucp-sdk==0.4.6 and [tool.uv.sources] redirects that dependency to ../python-sdk/, which this workflow checks out with no ref. The suite therefore runs against python-sdk main rather than the declared version, and any SDK release changes the result with no change here. This pins the checkout to v2026-04-08-6, matching ucp-sdk 0.4.6 declared in pyproject.toml.
damaz91
force-pushed
the
ci/pin-sdk-checkout
branch
from
September 7, 2026 22:06
54df3f1 to
9588d11
Compare
damaz91
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99.
pyproject.toml declares ucp-sdk==0.4.4 and [tool.uv.sources] redirects it to
../python-sdk/, which the workflow checks out with no ref. CI therefore runs
against python-sdk main rather than the declared version, and a new SDK release
changes this suite with no change here.
This pins the checkout to v2026-04-08-4, the tag that carries ucp-sdk 0.4.4, so
the workflow matches what the repository declares today. The tags map cleanly:
v2026-04-08-4 carries 0.4.4, v2026-04-08-5 carries 0.4.5 and v2026-04-08-6
carries 0.4.6, so the ref can follow the declared version whichever way you take
it.
Measured 2026-09-03 by replicating the workflow locally against conformance
fdbdafd: unpinned, the conformance environment resolves ucp-sdk 0.5.0; with this
ref, it resolves 0.4.4.
#96 proposes moving the declared version to 0.4.5. If that lands first, this ref
should become v2026-04-08-5 in the same change, and I am happy to rebase onto it
rather than have the two cross. I have pinned to the version declared today
rather than choosing a direction for you.
This does not by itself turn the scheduled run green. Two further causes are
tracked in samples: the reference server cannot start under 0.5.0, and the
checkout fixture builds a ShippingDestination where the request union expects
ShippingDestinationCreateRequest.