fix: reject unsupported lint output formats - #54
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ucp-schema lint --helpdocuments the output format astextorjson, butrun_lintonly checked forformat == "json"and silently treated any othervalue as text:
ucp-schema lint schema.json --format yaml # exit 0, text outputThat hides typos in scripts that expect machine-readable output.
Fix: reject unsupported lint output formats at the command boundary with
exit code 2 and a clear error message, while keeping
textandjsonbehaviorunchanged.
Category (Required)
Related Issues
N/A
Checklist
generate_models.shunder python_sdk. (Not applicable: ucp-schema CLI fix.)Screenshots / Logs (if applicable)
N/A —
cargo test --test cli_test lint_commandpassed 1/1 for the new test, the full Rust suite passed 316/316, and full pre-commit plusgit diff --checkpassed.