fix: validate examples through internal refs - #59
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
damaz91
approved these changes
Aug 17, 2026
carolinerg1
approved these changes
Aug 20, 2026
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_examplescompiled each schema node in isolation. A node that inherited its constraints through an internal$refsuch as#/$defs/positivetherefore lost the root document needed to resolve that reference. Validator compilation failed and the best-effort path skipped the examples, allowing an invalid documented value to pass linting.Fix: register the root schema as an in-memory resource and validate each examples array through a JSON Pointer to its enclosing schema node. Pointer tokens are escaped before building the reference, and unresolved external references keep the existing best-effort behavior.
The regression test uses a referenced positive-integer schema with examples
[0, 2]: only0producesE008. The updated linter also passes all 104 JSON documents under the UCPsource/tree with no errors.Category (Required)
Related Issues
N/A
Checklist
generate_models.shunderpython_sdk(not applicable).Screenshots / Logs (if applicable)
N/A — verified with
cargo test --all-targets,cargo clippy --all-targets -- -D warnings,cargo fmt --check, all pre-commit hooks, and a full lint of the UCPsource/tree.