fix: skip example instances during lint traversal - #60
Closed
FanouZeng-TT wants to merge 1 commit into
Closed
Conversation
damaz91
approved these changes
Aug 18, 2026
carolinerg1
approved these changes
Aug 20, 2026
17 tasks
Contributor
|
Thanks @FanouZeng-TT — real bug, correct repro, and it still reproduces on merged Closing in favour of #64 rather than as fixed: #64 covers the same traversal defect and extends it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_examplesvalidated each schema node'sexamplesarray and then recursively walked into that same array. Example values are instance data, not nested schemas. A valid object example containing business fields namedtypeandexampleswas therefore reinterpreted as a schema and produced a falseE008at/examples/0/examples/0.Fix: stop schema traversal at the
exampleskeyword after validating its entries. Other schema containers such asproperties,items, composition branches, and$defscontinue to be visited.The regression test uses a valid object example whose own
examplesfield contains the number123; linting now passes without diagnostics, while the existing invalid schema-level example test continues to reportE008.Category (Required)
Related Issues
N/A
Checklist
generate_models.shunderpython_sdk(not applicable).Screenshots / Logs (if applicable)
N/A — verified with
cargo test --all-targets,cargo clippy --all-targets -- -D warnings,cargo fmt --check, all pre-commit hooks, and the CLI regression fixture.