fix: preserve instance annotation fields - #62
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
damaz91
approved these changes
Aug 18, 2026
carolinerg1
approved these changes
Aug 20, 2026
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolve_objectandstrip_annotations_recursiverecurse into every object and array value.default,const,examples, andenumhold JSON instance data rather than child schemas, so business fields nameducp_requestorucp_responseinside those values were removed from resolved output.Fix: preserve those four instance-data keyword values verbatim while continuing to remove annotations from real schema locations. The regression test verifies both behaviors in one resolved schema.
Category (Required)
Related Issues
N/A
Checklist
Screenshots / Logs (if applicable)
cargo test --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/72-ucp-schema/Cargo.toml --all-targetscargo clippy --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/72-ucp-schema/Cargo.toml --all-targets -- -D warningscargo fmt --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/72-ucp-schema/Cargo.toml -- --checkuvx pre-commit run --all-files --show-diff-on-failuregit diff --check