-
Notifications
You must be signed in to change notification settings - Fork 458
feat: reserve the ucp protocol namespace, add map_order for registry ordering
#657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+316
−17
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37bb7d7
reserve `ucp` namespace, add map_order for registry ordering
igrigorik 6391c45
explain within-handler presentation preference
igrigorik 35954af
exclude dictionaries from the ambient namespace
igrigorik 622102d
prohibit direct namespace recursion
igrigorik 2b7ba41
define the ambient namespace validation contract
igrigorik a59ff01
clarify complete checkout signature coverage
igrigorik d191427
omit map_order from operation requests
igrigorik 4f1b2e6
define map_order target resolution
igrigorik 3d0ddd7
recover from duplicate map_order entries
igrigorik 9db46cc
move ambient validation to schema resolution
igrigorik 80fe7f1
Merge branch 'main' into feat/map-order
igrigorik e0104b5
tighten ambient namespace and ordering contracts
igrigorik 7872d37
Merge branch 'main' into feat/map-order
igrigorik 059f56a
clarify AP2 signature coverage
igrigorik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but for the sake of implementors and the community, we should aim to bend
schema-authoring.mdto be (i) as obvious as possible and (ii) example driven.So in this case something like:
More academic reasoning around why protocol level choices were made is rolled up into the specification itself.