upipe_ts_scte35_decoder: fix use-after-unmap in command handlers#1168
Closed
kierank wants to merge 1 commit into
Closed
upipe_ts_scte35_decoder: fix use-after-unmap in command handlers#1168kierank wants to merge 1 commit into
kierank wants to merge 1 commit into
Conversation
uref_ts_scte35_set_message reads from the scte35 pointer obtained via uref_block_read. Call it before uref_block_unmap in all three command handlers so the pointer is still valid when the data is copied. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
uref_ts_scte35_set_message does not write to the buffer but to an udict, so it can be done after the unmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uref_ts_scte35_set_message reads from the scte35 pointer obtained via uref_block_read. Call it before uref_block_unmap in all three command handlers so the pointer is still valid when the data is copied.