Skip to content

fix(mcp): pause active timeout during elicitation - #1956

Open
mikemikimike wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
mikemikimike:fix/1953-suspend-elicitation-timeout
Open

fix(mcp): pause active timeout during elicitation#1956
mikemikimike wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
mikemikimike:fix/1953-suspend-elicitation-timeout

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • pause the MCP tool's active-work deadline while one or more elicitation requests wait for user input
  • propagate MCP request/connection cancellation to pending elicitations and preserve the existing accept/decline/cancel mapping
  • keep the ordinary active-work timeout and add regression coverage for overlap, timeout, and connection-close behavior

Testing

  • bun run --cwd packages/plugins/mcp test -- src/sdk/invoke.test.ts
  • bun run format:check
  • bun run lint
  • bun run typecheck
  • git diff --check

The complete MCP package suite was also exercised; its only failure was the existing Windows stdio-env-isolation HOME safe-list assertion, while the remaining 37 files passed (296 tests, 29 skipped). The repository-wide test command has a Windows Bun argument-expansion issue, and unrelated parallel filesystem/cleanup failures were recorded separately.

Fixes #1953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] MCP tool timeout includes elicitation wait, leaving resume to replay a terminal failure

1 participant